From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C389126BF7 for ; Wed, 29 Oct 2025 14:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761747053; cv=none; b=Kz/db3D5NZYDVpZZU3idEIu/iRLlKvgg8/s2wLUGpzeTdAlUEbsFoF5437keQW+W2yMD9QzCrliCLnVYh+b3ZtaqpETYLYKtU6eYWnsw95RkwAiSGQ58+yfoNsU4KFclH46ZRX+lNQ3oL+rxDD6RdU253N/MCTnFlEXalsbPUYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761747053; c=relaxed/simple; bh=FtkXBRR1i74hdYvMHxT8SXn72fikHIr5QYRX/FKzjvM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ranJotoDOxFfz/aHh1pmf9EZboNypt+HNKDUfpqVUY4OOpbmwgjcNqIBONj+YyzMEYnWWBtVsy9IeS04g+wZkX8sEE5U6lr9L6PNdfwlSsIpw9rgy20nn5hdGF2v9GViepuWdp2ASfs6nNtWzvtw6CZ925uqCDD+aGCBCBksyeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=XtYF3cBQ; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XtYF3cBQ" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-87c1f61ba98so105479016d6.0 for ; Wed, 29 Oct 2025 07:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1761747050; x=1762351850; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3gCBuq56/59adr8Ol0O4W3+IsGMOD3y6s+9TcTsiPOY=; b=XtYF3cBQ/iUolTaq0Qh4Wu/3nUIzHeTXQKWw3P1uEJ7RX5J/q+NHSZ90s2g+2F7tak 5b0nlI5yabJThUBrmRjLTa1MrbtK2boO52QUqXpoG6pvXqItN1ByTDfFCk4wvSnbwVII UHKzqgWf/eR154V2f2iL1FBzr4RYaiE8Nxtrvpdwrlak7AmslIVYFSHLhJwSPdN0tmSU qUi6Iy2fUwbuXQPhaIkM/RLKVJXdsQOuUjUZZqz2Dy/XIrEkzLae8amIgt4NXfgy2Lnj AVKHykL6FOst8ffgc7l9mWVm9m8WEj3JTFjJAAE/YvzZmx03GvBm0xnVYzF5tmSl4PLV V6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761747050; x=1762351850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3gCBuq56/59adr8Ol0O4W3+IsGMOD3y6s+9TcTsiPOY=; b=BCP9KB8jaH+extdW9A5RUAdruZmKn6PwzaDGwTTCMdemEjA+erBSnaCnHjigKJsDHZ QYQ9gAiq5UurOQ61xjVgWWYBeXOabcB3LVMxgQyNjHQ8ZnydYl8PaK1lXIrArJ8SuAy6 /ilcWnbegZuMGlLy+nKqn4WM6ydJvr4Cop+AcR4hCIdjoMS7xw6qZaqafmkByKFI6GIj Q6/voTW9um635f2EQfTTv41HoXfiz5+yuNGxJ8XYmVtUZCVSZHL+uuY843+NH/0GTvGY kv0jZIwbFdiB3dp8WUkhvC+rVkfDeA2smYJOc5m11BJ7Saxm2droz26HjtaMgsvB6uiL eIZQ== X-Forwarded-Encrypted: i=1; AJvYcCWNgRV2Yxx6F2TbBeS5TpKL/dhCB5mtF7gAQvxpzZTlPJi3oy8I2gC/ShntZxCQ38qmqyOPY3Alu+u8@vger.kernel.org X-Gm-Message-State: AOJu0YygjDFdDP04WA45Fb7yBEiLnoQFhOaXh8fgiRI6+AFdHlc3tvr5 PNkZ2BeAcMtfGUVXELZrD+ymwQhwLMZRFooLr4+elkFWA8DGZ+XdYF1jg/CXW5BtiCI= X-Gm-Gg: ASbGncvrJn3P2Hr4++xzQ+E5e0kAKZ2+aHQ8x0lZWOMURw4iAbjNYFFIWxl+qljUCWF 2cx5x7qI7rKahQHCBrW+XlUi3Gwx5VJhHEWfrlakCENPz229MbmACfIU4Nl6vtZ2qlv8GRBSAXG TpHRH5V3HlbGgigj4yE4nbvBz82BkTWckFpuvECb/g1oX51qB8pXHwH36XdQyTSSH2/a5klrNhf fMGiuMczU0hWS9ZGLZ/kGuFG104bWBgksto2UE4YSjlls9exZQMCjE+i21ltTXOJvtUY794iBi5 5iMBoeeFT3LJJKtveAZ2wNZ6oVOh2SHhDEAKnbrYbomTALVX69MFc1Mg5rev6BuEApmTECf/fPR msnKEEdorpe4bv47WgvD5CHzhvr3BQ/hQPaAMSfsCEcZgMMxN91s7N5nin0e9G9iPwyc3ncn5hF nWICCaz6m+A93oKtyGU4iY4X7he7LraoipHbswcG0bA91PqI5QxdSgihyk X-Google-Smtp-Source: AGHT+IFN9EEFBAzfjpvQnmAHpqKEJbqdqdrZ9KL1PtSYGMem5wdE9qnodevFJl+GDHD76k8KE97qmg== X-Received: by 2002:a05:6214:23cb:b0:70d:fa79:baf0 with SMTP id 6a1803df08f44-88009be5c01mr41077486d6.38.1761747050399; Wed, 29 Oct 2025 07:10:50 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc494ab16sm98679066d6.39.2025.10.29.07.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 07:10:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vE6sy-00000004etU-2Jns; Wed, 29 Oct 2025 11:10:48 -0300 Date: Wed, 29 Oct 2025 11:10:48 -0300 From: Jason Gunthorpe To: Lorenzo Stoakes Cc: Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 00/12] remove is_swap_[pte, pmd]() + non-swap confusion Message-ID: <20251029141048.GN760669@ziepe.ca> References: <20251027160923.GF760669@ziepe.ca> <8d4da271-472b-4a32-9e51-3ff4d8c2e232@lucifer.local> <20251028124817.GH760669@ziepe.ca> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 28, 2025 at 06:20:54PM +0000, Lorenzo Stoakes wrote: > > > And use the new type right away. > > > > Then the followup series is cleaning away swap_entry_t as a name. > > OK so you're good with the typedef? This would be quite nice actually as we > could then use leaf_entry_t in all the core leafent_xxx() logic ahead of > time and reduce confusion _there_ and effectively document that swp_entry_t > is just badly named. Yeah, I think so, a commit message explaining it is temporary and a future series will mechanically rename it away and this is preparation. > I mean I'm not so sure that's all that useful, you often want to skip over > things that are 'none' entries without doing this conversion. Maybe go directly from a pte to the leaf entry type for this check? #define __swp_type(x) ((x).val >> (64 - SWP_TYPE_BITS)) That's basically free on most arches.. > We could use the concept of 'none is an empty leaf_entry_t' more thoroughly > internally in functions though. > > I will see what I can do. Sure, maybe something works out Though if we want to keep them seperate then maybe pte_is_leafent() is the right name for pte_none(). Reads so much better like this: if (pte_is_leafent(pte)) { leafent_t leaf = leafent_from_pte(pte) if (leafent_is_swap(leaf)) {..} } > > Then this: > > > > pmd_is_present_or_leafent(pmd) > > A PMD can be present and contain an entry pointing at a PTE table so I'm > not sure that helps... naming is hard :) pmd_is_leaf_or_leafent() In the PTE API we are calling present entries that are address, not tables, leafs. Jason