Re: [PATCH 3/3] Set the subfunctions called by finish_task_switch to be inline

Thomas Gleixner
2025-10-24T19:44:12Z

On Sat, Oct 25 2025 at 02:35, Xie Yuanbin wrote:
> #ifndef MODULE
> #define finish_arch_post_lock_switch \
> finish_arch_post_lock_switch
> -static inline void finish_arch_post_lock_switch(void)
> +static __always_inline void finish_arch_post_lock_switch_ainline(void)
> {
> struct mm_struct *mm = current->mm;
>
> if (mm && mm->context.switch_pending) {
> /*
> * Preemption must be disabled during cpu_switch_mm() as we
> * have some stateful cache flush implementations. Check
> * switch_pending again in case we were preempted and the
> * switch to this mm was already done.
> */
> preempt_disable();
> if (mm->context.switch_pending) {
> mm->context.switch_pending = 0;
> cpu_switch_mm(mm->pgd, mm);
> }
> preempt_enable_no_resched();
> }
> }
> +static inline void finish_arch_post_lock_switch(void)
> +{
> + finish_arch_post_lock_switch_ainline();

What is exactly the point of this indirection. Why can't you just mark
finish_arch_post_lock_switch() __always_inline and be done with it?