From: Heiko Carstens <hca@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Andreas Krebbel <krebbel@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [RFC PATCH 8/8] s390/syscalls: Switch to generic system call table generation
Date: Tue, 11 Nov 2025 12:36:47 +0100 [thread overview]
Message-ID: <20251111113647.8887B5c-hca@linux.ibm.com> (raw)
In-Reply-To: <f4531526-e981-4160-8369-50a8c8d86e36@app.fastmail.com>
On Mon, Nov 10, 2025 at 09:51:53PM +0100, Arnd Bergmann wrote:
> On Mon, Nov 10, 2025, at 19:54, Heiko Carstens wrote:
> > +161 common sched_rr_get_interval sys_sched_rr_get_interval
> > +162 common nanosleep sys_nanosleep
> > +163 common mremap sys_mremap
> > +167 common query_module
> > +168 common poll sys_poll
> > +169 common nfsservctl
> > +172 common prctl sys_prctl
>
> Nothing wrong with your patch, but while reading through this, I noticed
> that we are somewhat inconsistent about syscalls that are gone, with
> three possible methods:
>
> # 167 was query_module
> 167 common query_module sys_ni_syscall
> 167 common query_module
>
> You use the third one now, which is the same as x86 but nothing
> else. The second one using an explicit 'sys_ni_syscall' is the
> most common and has the same effect, so maybe use that as well.
Ok, will change.
> Eventually we may want to convert everything to the first method
> and drop the syscall macros, but that would be visible in
> user-space and might cause regression, so it should be a
> separate series across all architectures if we want to go there.
Yes, I thought about to remove them, but this is user space
visible. Therefore I kept it for now.
next prev parent reply other threads:[~2025-11-11 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 18:54 [RFC PATCH 0/8] s390: Remove compat support Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 1/8] s390/ptrace: Rename psw_t32 to psw32_t Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 2/8] s390/kvm: Use psw32_t instead of psw_compat_t Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 3/8] s390/syscalls: Add pt_regs parameter to SYSCALL_DEFINE0() syscall wrapper Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 4/8] tools: Remove s390 compat support Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 5/8] s390: Remove " Heiko Carstens
2025-11-10 21:33 ` Arnd Bergmann
2025-11-11 11:34 ` Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 6/8] s390/uapi: Remove 31 bit support from uapi header files Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 7/8] s390/syscalls: Remove system call table pointer from thread_struct Heiko Carstens
2025-11-10 18:54 ` [RFC PATCH 8/8] s390/syscalls: Switch to generic system call table generation Heiko Carstens
2025-11-10 20:51 ` Arnd Bergmann
2025-11-11 11:36 ` Heiko Carstens [this message]
2025-11-11 12:41 ` [RFC PATCH 0/8] s390: Remove compat support Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111113647.8887B5c-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).