From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF32A28A3F2; Thu, 27 Nov 2025 15:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764256069; cv=none; b=FR40jZi5RyhaQFm+BvU7Q6ERT1b+A+S9T5xvGuHeyBsiaSIFulx4XHxo7Y/unO5rX3TLYPOYGJVDy7h0cz0Ao3BcJY2v8v2bK5Gzg27TmJy3H3VVVZ6nM9+1ekln7ori7hoMpVZzKB9vqcbL8eBgfyWmZ0+dDM+4MJrGkBfPpHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764256069; c=relaxed/simple; bh=hEorKt3+pW5fjNyy+7jOJXddx93zSzDWF6f51d5ZfXM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=ahq42LrjwFgYARC7g+0PDybAsLeMY0ZyqqdTE+pSatL9hIHPLhX1gjDC2t+G9KyMtkb6/VM3BKhucChONcUwnaLGSJ3R/l/rD9p02LHkkf1SW2owaIasdbyC6pGkAy4HtIUO6xRCIEZU9CchChfM9f19RDEXscsYv2KiwozPyyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Lt2FIUu/; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Lt2FIUu/" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5AR28UHu024265; Thu, 27 Nov 2025 15:07:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pp1; bh=JIXV3Glwl28252V1OOyA+qGfOLOy 38osvoqG1FaWzuU=; b=Lt2FIUu/8lvQ+oJw9D+TdngaYiPEfv1QLYEPlI+dSQW6 su17y2LO15zQNItRiWnfsnVEIkFblB1cJ3Ur6suqVa5X6mU6GuWYFwaU7KgyuYD+ Ul96RvbhLhLIoGkxriK5vzooy0KUY5gBvUovKykoZQ9RNVWCJgMrLmMkNSjXUv4h tp7WEr76/SjYTG53m6PvdKaHtmmnDpXXeLh5hbwBCXmKe2uOek8NrkTVwiXYPEzn TdjK+sFK+gOPRLeQRnztIy49T/uz99MRGJ5xxBoZeutpSQ9BXQufcSaCpiFn7UzI X7O314PvTBqpJ5MdGsXKM2/KVkPLOAPykhIb/+S0sg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ak4pjad7v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Nov 2025 15:07:44 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5ARD0Dnj030842; Thu, 27 Nov 2025 15:07:43 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4akqgsrtad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Nov 2025 15:07:43 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5ARF7dEO44433748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Nov 2025 15:07:39 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B88BD20043; Thu, 27 Nov 2025 15:07:39 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 864DF20040; Thu, 27 Nov 2025 15:07:39 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Nov 2025 15:07:39 +0000 (GMT) From: Tobias Schumacher Subject: [PATCH v7 0/2] genirq: s390/pci: Migrate MSI interrupts to irqdomain API Date: Thu, 27 Nov 2025 16:07:36 +0100 Message-Id: <20251127-implement-msi-domain-v7-0-86c9a4837e8c@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIADhpKGkC/43QwW7DIAwG4FepOI8KGwPJTnuPaQcSzIpUkirpo k5V332k6iGqkmpHW+Lzz38VIw+JR/G+u4qBpzSmviuDe9uJ9uC7b5YplFmgQgOgSKZ8OnLm7iz zmGTos0+dDC2wV0CmUizK09PAMV3u7OdXmQ9pPPfD7/3KBPP2AYJaByeQSqIKaGzTaoTwcUzdz 2Wfmrxv+zzfeAD4AgClQwDUgYGegDnVhMsksAFhgaJVji3pumbaTOJeAL78tDTkECKvJdHLJNU GpAtkI1eRG/S1jmsQLSDcKpfmRAoaNhWDqfwaZJbQVjemQMGxAxdi0NGtQfY/kC0QEUXyllzd6 mfodrv9Ae7IrAirAgAA X-Change-ID: 20251104-implement-msi-domain-dc1ea014580e To: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Niklas Schnelle , Gerald Schaefer , Gerd Bayer , Halil Pasic , Matthew Rosato , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Tobias Schumacher , Farhan Ali X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDAxNiBTYWx0ZWRfX/3ddmtk+ZHdG ISLxlBE7T1UI2yNR8Hupr6LL37a2/gjoTlkcKdhVT/MhfpNchsPWYgXDyr7ESBorgw5jTT37twg Y2RDogPfIKjBODhot1l93Be6R0XuTGGsUo/ZzTy1dJ7WmlKexw/0asozt3ROt/4Wn74lw3dUwTH zaddDYoLx1ivfdFLavWSsy5Df8TneZNuPPpn9ceUiavawoSa3bKFfQeOt5OUG+ywQrTsatbTveE wzCWEPkSzc4Osy30uXJpWQcrI0gByOJEALaYJBrupRgdA0NdmNG/KDJUv1VgRXYnYFQeNmNhF5s pqag4lBBh9XVv83kP870rpDzjtI+5UrtaUMGoFUo7tbxnCZ/VwiPIC2L4JUErRBx9fTSTk9wgD2 i+FUn/uk7HY+xmRaYTrO5UyphcQcYg== X-Proofpoint-ORIG-GUID: 6LJ0ilRxzfy6bIP0x_GOsj0ukVqL09-8 X-Authority-Analysis: v=2.4 cv=CcYFJbrl c=1 sm=1 tr=0 ts=69286940 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=qu2NodEISbj6-X0eVIsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 6LJ0ilRxzfy6bIP0x_GOsj0ukVqL09-8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 phishscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2511220016 This patch series reworks the PCIe interrupt handling on s390 by migrating it to use a proper MSI parent domain. Introducing a dedicated MSI domain hierarchy aligns s390 PCIe support with the generic Linux IRQ domain model. Currently s390 is one of the last architectures still using the legacy API. The migration splits the existing code in the legacy functions arch_setup_msi_irqs() and arch_teardown_msi_irqs() into different callbacks of the newly created MSI parent domain: - zpci_msi_prepare(): prepare the allocation of per-device MSI IRQs. will be called once for each device before allocating individual IRQs and sets up for example the adapter aisb and aibv. - zpci_msi_teardown(): reverts the effects of zpci_msi_prepare() and is called after all MSI IRQs are freed. - zpci_msi_domain_alloc(): the allocation function for interrupts - zpci_msi_domain_free(): revert the effects of zpci_msi_domain_alloc() - zpci_compose_msi_msg(): create the MSI message to be written into the corresponding PCI config space. * Patch 1 fixes an inconsistency in the irqdomain API. Internally, hw irqs are represented by an unsigned long int (irq_hw_number_t) while the external API in some cases takes an unsigned int as parameter. This fix was required in V2 of the patchset. Due to conceptual changes in patch 2 it is not required anymore for s390, but still seems sensible. * Patch 2 implements IRQ domains for s390 PCI Since patch 1 changes common APIs, some build tests were done for x86_64 and arm64. Signed-off-by: Tobias Schumacher --- Changes in v7: - call zpci_set_irq() in zpci_reenable_device() to fix recovery after zpcictl --reset-fw - add commas at end of initializers - remove unused variables in free() - removed R-b for patch 2 because of bug fixes - Link to v6: https://lore.kernel.org/r/20251121-implement-msi-domain-v6-0-444f4a6479c3@linux.ibm.com Changes in v6: - removed obsolete function zpci_decode_hwirq_msi_index() - removed some code duplication - fixed some coding style issues - corrected hwirq encoding in commit message - Link to v5: https://lore.kernel.org/r/20251121-implement-msi-domain-v5-0-d7e717dfd3f7@linux.ibm.com Changes in v5: - removed two lines of superfluous code - Link to v4: https://lore.kernel.org/r/20251120-implement-msi-domain-v4-0-a01be58e158a@linux.ibm.com Changes in v4: - remove flag MSI_FLAG_PCI_MSI_MASK_PARENT and mask/unmask callbacks - use goto statements in zpci_bus_create_pci_bus() - Link to v3: https://lore.kernel.org/r/20251118-implement-msi-domain-v3-0-6fe8feb2a93f@linux.ibm.com Changes in v3: - implement one MSI parent domain per PCI domain to further align the implementation with other architectures. - Link to v2: https://lore.kernel.org/r/20251117-implement-msi-domain-v2-0-a110ea0721fe@linux.ibm.com Changes in v2: - fix directed interrupt setup and handling - add flag MSI_FLAG_NO_AFFINITY in case of floating interrupts - style adjustments according to review comments - Link to v1: https://lore.kernel.org/r/20251112-implement-msi-domain-v1-0-103dd123de14@linux.ibm.com --- Tobias Schumacher (2): genirq: Change hwirq parameter to irq_hw_number_t s390/pci: Migrate s390 IRQ logic to IRQ domain API arch/s390/Kconfig | 1 + arch/s390/include/asm/pci.h | 5 + arch/s390/pci/pci.c | 6 + arch/s390/pci/pci_bus.c | 18 ++- arch/s390/pci/pci_irq.c | 310 ++++++++++++++++++++++++++++---------------- include/linux/irqdesc.h | 6 +- kernel/irq/irqdesc.c | 6 +- 7 files changed, 230 insertions(+), 122 deletions(-) --- base-commit: 82ef9f0fac73cca3e7d776b095b5a7de1b0b88fc change-id: 20251104-implement-msi-domain-dc1ea014580e Best regards, -- Tobias Schumacher