From: Peter Zijlstra <peterz@infradead.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: remove kvm_types.h from Kbuild
Date: Thu, 5 Feb 2026 09:39:47 +0100 [thread overview]
Message-ID: <20260205083947.GC232055@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260205074643.7870A22-hca@linux.ibm.com>
On Thu, Feb 05, 2026 at 08:46:43AM +0100, Heiko Carstens wrote:
> On Tue, Feb 03, 2026 at 10:42:04AM -0800, Randy Dunlap wrote:
> > kvm_types.h is mandatory in include/asm-generic/Kbuild so having it
> > in another Kbuild file causes a warning. Remove it from the arch/
> > Kbuild file to fix the warning.
> >
> > ../scripts/Makefile.asm-headers:39: redundant generic-y found in ../arch/s390/include/asm/Kbuild: kvm_types.h
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > arch/s390/include/asm/Kbuild | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- linux-next-20260202.orig/arch/s390/include/asm/Kbuild
> > +++ linux-next-20260202/arch/s390/include/asm/Kbuild
> > @@ -5,6 +5,5 @@ generated-y += syscall_table.h
> > generated-y += unistd_nr.h
> >
> > generic-y += asm-offsets.h
> > -generic-y += kvm_types.h
> > generic-y += mcs_spinlock.h
> > generic-y += mmzone.h
>
> This should go via perf/core from the tip tree, since Peter's not-yet upstream
> commit 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the mediated
> APIs") adds the mandatory-y statement to include/asm-generic/Kbuild.
>
> Peter?
Let me see if I can manage to apply a patch I don't have ;-)
prev parent reply other threads:[~2026-02-05 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 18:42 [PATCH] s390: remove kvm_types.h from Kbuild Randy Dunlap
2026-02-05 7:46 ` Heiko Carstens
2026-02-05 8:39 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205083947.GC232055@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox