From: Heiko Carstens <hca@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/3] s390: Fix and improve inline assembly constraints
Date: Mon, 2 Mar 2026 15:40:02 +0100 [thread overview]
Message-ID: <20260302144002.22209D5c-hca@linux.ibm.com> (raw)
In-Reply-To: <20260302134751.GA21924@lst.de>
On Mon, Mar 02, 2026 at 02:47:51PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 02, 2026 at 02:34:57PM +0100, Heiko Carstens wrote:
> > While looking at xor_xc_2() I realized that its inline assembly constraints
> > are incorrect. Also the inline assembly constraints for the other xor()
> > function look incorrect, but are not (execute instruction vs register
> > zero). However that revealed another real bug on __stackleak_poison() with
> > another incorrect inline assembly constraint.
>
> No expert on the constraints, but have you considered to just convert
> this code to pure assembly?
In general I don't like pure assembly files, since they come without any
instrumentation. Of course you could (correctly) argue that's the case for the
current inline assembly as well (except for ftrace). However the rest can be
easily fixed/addressed.
But I don't want to rush in even more code to make your life more complicated.
> Otherwise please try to get it into Linus' tree ASAP so that I easily
> rebase on that for the XOR series.
Sure, that should happen before rc3 comes out.
next prev parent reply other threads:[~2026-03-02 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:34 [PATCH 0/3] s390: Fix and improve inline assembly constraints Heiko Carstens
2026-03-02 13:34 ` [PATCH 1/3] s390/xor: Fix xor_xc_2() " Heiko Carstens
2026-03-02 15:41 ` Vasily Gorbik
2026-03-02 13:34 ` [PATCH 2/3] s390/xor: Improve " Heiko Carstens
2026-03-02 16:02 ` Vasily Gorbik
2026-03-02 13:35 ` [PATCH 3/3] s390/stackleak: Fix __stackleak_poison() inline assembly constraint Heiko Carstens
2026-03-02 15:40 ` Vasily Gorbik
2026-03-02 13:47 ` [PATCH 0/3] s390: Fix and improve inline assembly constraints Christoph Hellwig
2026-03-02 14:40 ` Heiko Carstens [this message]
2026-03-02 16:13 ` Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302144002.22209D5c-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox