From: Alex Williamson <alex@shazbot.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
akrowiak@linux.ibm.com, linux-s390@vger.kernel.org,
alex@shazbot.org
Subject: Re: [PATCH] VFIO: remove dead notifier code
Date: Fri, 10 Apr 2026 13:32:00 -0600 [thread overview]
Message-ID: <20260410133200.7010cf27@shazbot.org> (raw)
In-Reply-To: <20260410181006.GF2551565@ziepe.ca>
On Fri, 10 Apr 2026 15:10:06 -0300
Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Tue, Apr 07, 2026 at 07:59:34PM +0200, Paolo Bonzini wrote:
> > group->notifier is dead code. VFIO initializes it and checks it for emptiness on
> > teardown, but nobody ever registers on it or triggers it.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > Documentation/arch/s390/vfio-ap.rst | 18 ++++++------------
> > drivers/vfio/group.c | 3 ---
> > drivers/vfio/vfio.h | 1 -
> > drivers/vfio/vfio_iommu_type1.c | 1 -
> > 4 files changed, 6 insertions(+), 17 deletions(-)
>
> Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM")
>
> ?
Technically yes, but is it really worth having stable pick this up?
Seems not. Thanks,
Alex
prev parent reply other threads:[~2026-04-10 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 17:59 [PATCH] VFIO: remove dead notifier code Paolo Bonzini
2026-04-08 14:34 ` Anthony Krowiak
2026-04-08 14:36 ` Paolo Bonzini
2026-04-08 22:00 ` Paolo Bonzini
2026-04-09 11:55 ` Anthony Krowiak
2026-04-10 18:10 ` Jason Gunthorpe
2026-04-10 19:32 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410133200.7010cf27@shazbot.org \
--to=alex@shazbot.org \
--cc=akrowiak@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox