public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: pbonzini@redhat.com
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, david@kernel.org,
	borntraeger@linux.ibm.com, cohuck@redhat.com,
	linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	Steffen Eiden <seiden@linux.ibm.com>
Subject: [GIT PULL 09/12] KVM: s390: Allow 4k granularity for memslots
Date: Mon, 13 Apr 2026 12:46:37 +0200	[thread overview]
Message-ID: <20260413104721.203024-10-frankja@linux.ibm.com> (raw)
In-Reply-To: <20260413104721.203024-1-frankja@linux.ibm.com>

From: Claudio Imbrenda <imbrenda@linux.ibm.com>

Until now memslots on s390 needed to have 1M granularity and be 1M
aligned. Since the new gmap code can handle memslots with 4k
granularity and alignment, remove the restrictions.

Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index a583c0a00efd..156878c95e06 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -5642,8 +5642,6 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm,
 				   struct kvm_memory_slot *new,
 				   enum kvm_mr_change change)
 {
-	gpa_t size;
-
 	if (kvm_is_ucontrol(kvm) && new->id < KVM_USER_MEM_SLOTS)
 		return -EINVAL;
 
@@ -5653,20 +5651,14 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm,
 
 	if (change != KVM_MR_DELETE && change != KVM_MR_FLAGS_ONLY) {
 		/*
-		 * A few sanity checks. We can have memory slots which have to be
-		 * located/ended at a segment boundary (1MB). The memory in userland is
-		 * ok to be fragmented into various different vmas. It is okay to mmap()
-		 * and munmap() stuff in this slot after doing this call at any time
+		 * A few sanity checks. The memory in userland is ok to be
+		 * fragmented into various different vmas. It is okay to mmap()
+		 * and munmap() stuff in this slot after doing this call at any
+		 * time.
 		 */
-
-		if (new->userspace_addr & 0xffffful)
+		if (new->userspace_addr & ~PAGE_MASK)
 			return -EINVAL;
-
-		size = new->npages * PAGE_SIZE;
-		if (size & 0xffffful)
-			return -EINVAL;
-
-		if ((new->base_gfn * PAGE_SIZE) + size > kvm->arch.mem_limit)
+		if ((new->base_gfn + new->npages) * PAGE_SIZE > kvm->arch.mem_limit)
 			return -EINVAL;
 	}
 
-- 
2.53.0


  parent reply	other threads:[~2026-04-13 10:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 10:46 [GIT PULL 00/12] KVM: s390: Changes for 7.1 Janosch Frank
2026-04-13 10:46 ` [GIT PULL 01/12] KVM: s390: only deliver service interrupt with payload Janosch Frank
2026-04-13 10:46 ` [GIT PULL 02/12] KVM: s390: Fix lpsw/e breaking event handling Janosch Frank
2026-04-13 10:46 ` [GIT PULL 03/12] KVM: s390: vsie: Allow non-zarch guests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 04/12] KVM: s390: vsie: Disable some bits when in ESA mode Janosch Frank
2026-04-13 10:46 ` [GIT PULL 05/12] KVM: s390: vsie: Accommodate ESA prefix pages Janosch Frank
2026-04-13 10:46 ` [GIT PULL 06/12] KVM: s390: Add KVM capability for ESA mode guests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 07/12] KVM: s390: Add some useful mask macros Janosch Frank
2026-04-13 10:46 ` [GIT PULL 08/12] KVM: s390: Add alignment checks for hugepages Janosch Frank
2026-04-13 10:46 ` Janosch Frank [this message]
2026-04-13 10:46 ` [GIT PULL 10/12] KVM: selftests: Remove 1M alignment requirement for s390 Janosch Frank
2026-04-13 10:46 ` [GIT PULL 11/12] KVM: s390: selftests: enable some common memory-related tests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 12/12] KVM: s390: ucontrol: Fix memslot handling Janosch Frank
2026-04-13 11:23 ` [GIT PULL 00/12] KVM: s390: Changes for 7.1 Paolo Bonzini
2026-04-13 12:28   ` Janosch Frank
2026-04-13 12:33     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260413104721.203024-10-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seiden@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox