From: Janosch Frank <frankja@linux.ibm.com>
To: pbonzini@redhat.com
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, david@kernel.org,
borntraeger@linux.ibm.com, cohuck@redhat.com,
linux-s390@vger.kernel.org, imbrenda@linux.ibm.com
Subject: [GIT PULL 02/12] KVM: s390: Fix lpsw/e breaking event handling
Date: Mon, 13 Apr 2026 12:46:30 +0200 [thread overview]
Message-ID: <20260413104721.203024-3-frankja@linux.ibm.com> (raw)
In-Reply-To: <20260413104721.203024-1-frankja@linux.ibm.com>
LPSW and LPSWE need to set the gbea on completion but currently don't.
Time to fix this up.
LPSWEY was designed to not set the bear.
Fixes: 48a3e950f4cee ("KVM: s390: Add support for machine checks.")
Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
arch/s390/kvm/priv.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c
index a3250ad83a8e..cc0553da14cb 100644
--- a/arch/s390/kvm/priv.c
+++ b/arch/s390/kvm/priv.c
@@ -714,12 +714,13 @@ int kvm_s390_handle_lpsw(struct kvm_vcpu *vcpu)
{
psw_t *gpsw = &vcpu->arch.sie_block->gpsw;
psw32_t new_psw;
- u64 addr;
+ u64 addr, iaddr;
int rc;
u8 ar;
vcpu->stat.instruction_lpsw++;
+ iaddr = gpsw->addr - kvm_s390_get_ilen(vcpu);
if (gpsw->mask & PSW_MASK_PSTATE)
return kvm_s390_inject_program_int(vcpu, PGM_PRIVILEGED_OP);
@@ -737,18 +738,20 @@ int kvm_s390_handle_lpsw(struct kvm_vcpu *vcpu)
gpsw->addr = new_psw.addr & ~PSW32_ADDR_AMODE;
if (!is_valid_psw(gpsw))
return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
+ vcpu->arch.sie_block->gbea = iaddr;
return 0;
}
static int handle_lpswe(struct kvm_vcpu *vcpu)
{
psw_t new_psw;
- u64 addr;
+ u64 addr, iaddr;
int rc;
u8 ar;
vcpu->stat.instruction_lpswe++;
+ iaddr = vcpu->arch.sie_block->gpsw.addr - kvm_s390_get_ilen(vcpu);
if (vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PSTATE)
return kvm_s390_inject_program_int(vcpu, PGM_PRIVILEGED_OP);
@@ -761,6 +764,7 @@ static int handle_lpswe(struct kvm_vcpu *vcpu)
vcpu->arch.sie_block->gpsw = new_psw;
if (!is_valid_psw(&vcpu->arch.sie_block->gpsw))
return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
+ vcpu->arch.sie_block->gbea = iaddr;
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-13 10:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 10:46 [GIT PULL 00/12] KVM: s390: Changes for 7.1 Janosch Frank
2026-04-13 10:46 ` [GIT PULL 01/12] KVM: s390: only deliver service interrupt with payload Janosch Frank
2026-04-13 10:46 ` Janosch Frank [this message]
2026-04-13 10:46 ` [GIT PULL 03/12] KVM: s390: vsie: Allow non-zarch guests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 04/12] KVM: s390: vsie: Disable some bits when in ESA mode Janosch Frank
2026-04-13 10:46 ` [GIT PULL 05/12] KVM: s390: vsie: Accommodate ESA prefix pages Janosch Frank
2026-04-13 10:46 ` [GIT PULL 06/12] KVM: s390: Add KVM capability for ESA mode guests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 07/12] KVM: s390: Add some useful mask macros Janosch Frank
2026-04-13 10:46 ` [GIT PULL 08/12] KVM: s390: Add alignment checks for hugepages Janosch Frank
2026-04-13 10:46 ` [GIT PULL 09/12] KVM: s390: Allow 4k granularity for memslots Janosch Frank
2026-04-13 10:46 ` [GIT PULL 10/12] KVM: selftests: Remove 1M alignment requirement for s390 Janosch Frank
2026-04-13 10:46 ` [GIT PULL 11/12] KVM: s390: selftests: enable some common memory-related tests Janosch Frank
2026-04-13 10:46 ` [GIT PULL 12/12] KVM: s390: ucontrol: Fix memslot handling Janosch Frank
2026-04-13 11:23 ` [GIT PULL 00/12] KVM: s390: Changes for 7.1 Paolo Bonzini
2026-04-13 12:28 ` Janosch Frank
2026-04-13 12:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413104721.203024-3-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox