Re: [PATCH v2 3/6] s390/mm: Complete ptep_get() conversion

Heiko Carstens
2026-04-23T10:51:34Z

On Wed, Apr 15, 2026 at 05:01:21PM +0200, Alexander Gordeev wrote:
> Finalize commit c33c794828f2 ("mm: ptep_get() conversion") and
> replace direct page table entry dereferencing with the proper
> accessors (ptep_get(), pmdp_get(), etc.).
>
> Override the default getter implementations even though they are
> currently identical: pud_clear(), p4d_clear(), and pgd_clear()
> require corresponding architecture-specific getters, but these
> are not yet defined. This avoids a dependency loop.
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> arch/s390/boot/vmem.c | 32 +++++++------
> arch/s390/include/asm/hugetlb.h | 2 +-
> arch/s390/include/asm/pgtable.h | 60 ++++++++++++++++++------
> arch/s390/mm/hugetlbpage.c | 12 ++---
> arch/s390/mm/pageattr.c | 42 +++++++++--------
> arch/s390/mm/vmem.c | 82 ++++++++++++++++++---------------
> 6 files changed, 138 insertions(+), 92 deletions(-)

Was this a manual conversion, or did you use some tooling?

I'm wondering since I can spot not converted locations, e.g. one in
__kernel_map_pages().

Besides that:
Acked-by: Heiko Carstens <hca@linux.ibm.com>