From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C95953A63E3; Wed, 3 Jun 2026 22:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780526820; cv=none; b=Vf9VKOajuGHYSJbpOVeo0pi+oBH4Ko8CT3f0LA19o33JT9Gix9zbZaPB1aLL1H33yo0LA0/LPcLPAufNS3oPOaZTiZ5hLp/uBv7nyx9E5qNYfk/v6DOtT4Z9LfpjdoZ81jn0LJU3xYABxOgkiss04Lo5hN39lzmvRE4bihcM/dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780526820; c=relaxed/simple; bh=/sGv8vqrEIUPJa9DsW4mcTchRLPerXGfVwWW0hz7DaM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ojv9jFkZFGHvB8LRaKo0EFoq5bFGzbY2U6swMohTmU9xA9nLR8zwJqwESiuIgNCXGwIM+PEMaoJgRnOBRGHgZ+stxIWgKFdm5Y9R9IJNxdA09HGxN4GR7GKOMaddCpmzr1mbgubIlPQzxvd/yzTb75SVoZC7lJmLTyjszaIyDKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=hexmOFas; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=aq+RYKJP; arc=none smtp.client-ip=202.12.124.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="hexmOFas"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="aq+RYKJP" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 0A8651D0008A; Wed, 3 Jun 2026 18:46:58 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 03 Jun 2026 18:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1780526817; x=1780613217; bh=ly6jMDgbX4xN6wPWO17/Ooj7q7iXng0dSBpqivMnvW4=; b= hexmOFasjzpCZcCJELdKPaY38LzJzwAioTt+HPPwgvImZF75M+6UgEoGcM8WS8ji W2v6b75uv19OufNIur74MdBEETKLvC8UHrpxKIGVwf1fqirNBILmffUNQhuBXGmL 2KFIb06zRYBjBvaEvDFInP2jRY0xs4Kj4Kn1/fBpbs27HIFr6UkAWPaoLmfyr6D+ cRtt6NiwyRpLbjVcRLho24x8jqCctAhSfLAeYIxXSGvOy7uFjf3qGRtmKqOIu+c6 YVt+hp7cFoyOCOdGQSLzJrm0qCO5crez6FO7D9LLux+G6Noy7/z33hpK+hbgOoXw plgwJWhuCjIrDCHZh8wB/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1780526817; x= 1780613217; bh=ly6jMDgbX4xN6wPWO17/Ooj7q7iXng0dSBpqivMnvW4=; b=a q+RYKJPm9LDAVhLRLlUhEj5xEP+OuZULEaWzHz5R4Ik0LrEYJY87gkZO2QSLoV7a xdAYdoWOhv7tLutGuGaKJHAAuFbB0wYdJ1K6nIg9EcnYzm6VM/BziDEF0clSZdar +BPgPiBWcEQZe45cL/JBO8/fDyKV5rVXyXTvJ/zBh99+/NjhpdpWuGtQ4MKBCM1y k7KeBCF0c2bqAaFjdmRvA34uQKk5dslt2hylXUYrWQ5CTRvOn7LgKWfDe+90O9bS Zl2Ka/wX+UsZy2ht8uFgjph9P/L3+Fy/FxVZkCm43qo9V/ID7xuZn47REL1derpI RaxQL2kX32KgfFhi0Gkpw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFgoydlopjKJjKdl830FpBqqJdCKJDFNUb9+yRv2ZGZk9tc7+jMaAVGne97Tzsh8B QipyZfFi1M8xdZyGcq6uXnlybJk5mLxCNPVGsgS49QTznyI1rnQZMXEaWQ0Vy7f0bKrRr7 ZJTcF8m87L6HkYvZyuUmWNt92Dg+ribrX+if8+cGxzxzk3B3A56W9qe+cAVyMIOduL8AXh xZ6uGqEm62a9o6CyG1n9UuX3cQwZMUwx/iOsmJyEiFEKan1d6sVz9H1fc8+AIbyM6o49YV 6A9b8VUsaAozroq+FvRjt3nIK/B1CPWdqPXaxPylZE5FWKAv7iGLcxDx2nTB2vKsFqxUqn DulsgQzOo71s6KzV6nsOy6z+sKN+Y4KdqVMZZRHNYvveVCoP7wzCjyYJG3dOX8e3IqdCpe ET+4a1Cs81EPK6yObNawLjAvNt91/VQICQm21PrY6LCdVNB9r0uxSL8Lvc3GHWEFLpvkIV k22hWVK940a03NA9GPZBZv+PdqnVqGI1+855ueQOlU/b30tjjs2kZw2VHLeXTRbB6YgO7I 9h7NuKJRVK/xjI8GA4Zm+rHzi1+sGJ+5hsNOZpr/uW1YySaDJVE3hPo032zwy+zGJEg64r z/2CuB8FfudRHvdnv/zn4ceGsHc79nbC8a9V9GMkGgQNxQvsgi6HH0Bnc2aw X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Jun 2026 18:46:56 -0400 (EDT) Date: Wed, 3 Jun 2026 16:46:55 -0600 From: Alex Williamson To: Farhan Ali Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, helgaas@kernel.org, schnelle@linux.ibm.com, mjrosato@linux.ibm.com, Julian Ruess , alex@shazbot.org Subject: Re: [PATCH v18 3/4] vfio/pci: Add a reset_done callback for vfio-pci driver Message-ID: <20260603164655.1f533ea5@shazbot.org> In-Reply-To: <20260603182415.2324-4-alifm@linux.ibm.com> References: <20260603182415.2324-1-alifm@linux.ibm.com> <20260603182415.2324-4-alifm@linux.ibm.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jun 2026 11:24:14 -0700 Farhan Ali wrote: > On error recovery for a PCI device bound to vfio-pci driver, we want to > recover the state of the device to its last known saved state. The callback > restores the state of the device to its initial saved state. > > Reviewed-by: Julian Ruess > Reviewed-by: Niklas Schnelle > Acked-by: Alex Williamson > Reviewed-by: Matthew Rosato > Signed-off-by: Farhan Ali > --- > drivers/vfio/pci/vfio_pci_core.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Sashiko has some interesting comments: https://sashiko.dev/#/patchset/20260603182415.2324-4-alifm@linux.ibm.com I think the critical is a calculated risk we're taking, restoring the hand-off state after reset. I don't think we'd considered the race, and it seems the commit log could use some improvement, especially if we do need to revisit this based on the calculated risk. Thanks, Alex