From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240FE3E2ABB; Fri, 12 Jun 2026 12:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781268161; cv=none; b=R+5Mjzsqv+u5L3niy5bOZxgn35c7Fun1DKzjEhnVgrmMluIoH3N+UUO4cRRN1nbznuUZcqriv6q7Bs/rHtb9k1w7D4YwKoHGkks3BDXyOncpFXufPvd4BM0kRoGBjZkjZe/sLZSKX+zey9vfjXDG2XiVCAaQyfD1lpTGI+JdgJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781268161; c=relaxed/simple; bh=9DiUdu9Cevk6g9+QHdS2/l+7K81+YdfJnDkSVSXZMfg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=MmS6+ZiYINfPbrVJiWb1XHEhhRGc/L8oN++6887SdLzPiYw8/W1oXfnMqoBCTUHeige4ET05nVJd/jdf98CjeiLFy6quV1kIUQ2TBqsVSl5gxnPPsexbCR3SMpa4v9fRL+F8gktp8F/GyOnGDMPFO6S/pxWyCyn01ja7i8HbqcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MAf9Seln; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MAf9Seln" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E68B1F00A3A; Fri, 12 Jun 2026 12:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781268159; bh=RgL8Y3oOAr8EaxDC1KuoLqUI2TNKEcYOZozUX58UI68=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MAf9Selnw6lXrRzRwD//GCOKystzG943ty9yTN70p9W+ZLM7e+BfPwfWsmAU6YgDC VLw8enCJQy/bi4N6CC5SjHD9mp8HkgLK/+PQgNKuu49ZbSDUg/CcOAFAFFv9OnfyTJ BicI8cGMjtADcRoL2ouHDrQfI6p6JMMRsCbCi/VRb+GQ+Ywfyd6ZSX+rEqUJKlYUix HECNZWBhp5Hql1GAuf59Zlwlm81D1fM+hhMun0c6iBK2yS2LD6DliCGIC7Oc7vlDQk WNsbJuQChucn6ghx2dbUPVLPZ07Yp8V0ippA+jPImK8xYJt1Yp3ZF25LHc4oHRTqMd AjNkTQwRKrwJw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 4/4] KVM: s390: vsie: Implement ASTFLEIE facility 2 Reply-To: sashiko-reviews@lists.linux.dev To: "Christoph Schlameuss" Cc: "Heiko Carstens" , kvm@vger.kernel.org, linux-s390@vger.kernel.org, "Alexander Gordeev" , "Vasily Gorbik" In-Reply-To: <20260612-vsie-alter-stfle-fac-v4-4-74f0e1559929@linux.ibm.com> References: <20260612-vsie-alter-stfle-fac-v4-4-74f0e1559929@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jun 2026 12:42:38 +0000 Message-Id: <20260612124239.6E68B1F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Incorrect offset comment for `fac` array in `struct vsie_page`. -- commit 533d12a005c16677069ec80d3450892c247155e9 Author: Nina Schoetterl-Glausch KVM: s390: vsie: Implement ASTFLEIE facility 2 This commit implements shadowing of the format-2 facility list when running in VSIE, introducing ASTFLEIE2 support. > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > index 2ea3bbaf568e5..4c20bd787b8b2 100644 > --- a/arch/s390/kvm/vsie.c > +++ b/arch/s390/kvm/vsie.c > @@ -65,9 +65,9 @@ struct vsie_page { > gpa_t scb_gpa; /* 0x0258 */ > /* the shadow gmap in use by the vsie_page */ > struct gmap_cache gmap_cache; /* 0x0260 */ > - __u8 reserved[0x0700 - 0x0278]; /* 0x0278 */ > - struct kvm_s390_crypto_cb crycb; /* 0x0700 */ > - __u8 fac[S390_ARCH_FAC_LIST_SIZE_BYTE]; /* 0x0800 */ > + __u8 reserved[0x06f8 - 0x0278]; /* 0x0278 */ > + struct kvm_s390_crypto_cb crycb; /* 0x06f8 */ > + __u8 fac[8 + S390_ARCH_FAC_LIST_SIZE_BYTE];/* 0x0800 */ [Severity: Low] This isn't a bug, but the comment indicating the offset for the fac array appears to be incorrect after this layout change. Since crycb was shifted back 8 bytes to start at 0x06f8, and=20 struct kvm_s390_crypto_cb is 256 bytes in size (0x0100), the fac array=20 now starts at 0x07f8.=20 Should this comment be updated to /* 0x07f8 */ to reflect the new offset? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260612-vsie-alter= -stfle-fac-v4-0-74f0e1559929@linux.ibm.com?part=3D4