From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663ED364943; Thu, 9 Jul 2026 15:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610675; cv=none; b=FDLym5zYkuy3yKv2/T010ySWfeES57o2u4Vp77cFFag/vQzSG7/IVtivHPOvvAWKf3TrmkA1fci4ClRLJ8JC7r1Zt9QD4yDkCezTqzbXEDgr58c4fI1xA+Ju3iBU2EFLe51q0GVQ7aWQJIXIEIEVyJaYmVmaxvGLuwvW7bEJ4V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610675; c=relaxed/simple; bh=W8SO31V8xUOf45PJlAmABNrfzovD5P4lFYjslpvXefs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ZDPr+z16uXekCrCpu3g+kYak64MJ8TISZN9fW6YEd8Sz97B2gLqLm1frmJjWV7W2uVGc4wjf+JIhz7ymfTHNzpvXpdClUKdvPPxCRW1sZ5I0UqYq9JtgFz7XHg7BxCuEQ25aPE9Klk6qb99jOgV1q7XMoBVTVzGlZAr2cF4isDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eyutX1GF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eyutX1GF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CBA51F000E9; Thu, 9 Jul 2026 15:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783610674; bh=W8SO31V8xUOf45PJlAmABNrfzovD5P4lFYjslpvXefs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eyutX1GFw4Hhk8rxKaDa51o4J28/OuVH0wuJVj29/LZvaryyTLqIz6loQKjiD5ZYA 5ovdRvhBKdWoJfSFdo4gZL/XfKmLm90vTfAnc8aFY8kgigXuLEAwO6trEMZM1yIju3 ubSjMXFNfKTp1IA5tvda/JH1QYfVpC324Ts0XygtDQjJLcrlq7JUvRAkF6QNcnBoml g3ecljuRCzBF9vkQb43QpHj+g+fjaBwsUMwDUT4Ie0Ve3O9vpL5022UOwgS4RFsVKR Bgn2oy2LX5epWlkNZnAqjjJZvvkGEVlU/5dWaBDEWyzqlDlNhFPiXu+fc2aN4QOTvd d6Pxrhw2ASkDg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 07/21] KVM: s390: vsie: Add ssca_block and ssca_entry structs for vsie_ie Reply-To: sashiko-reviews@lists.linux.dev To: "Christoph Schlameuss" Cc: "Heiko Carstens" , "Alexander Gordeev" , "Vasily Gorbik" , linux-s390@vger.kernel.org, kvm@vger.kernel.org In-Reply-To: <20260709-vsie-sigpi-v1-7-ea9f12066408@linux.ibm.com> References: <20260709-vsie-sigpi-v1-0-ea9f12066408@linux.ibm.com> <20260709-vsie-sigpi-v1-7-ea9f12066408@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 15:24:32 +0000 Message-Id: <20260709152433.9CBA51F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Meaningful code and commit message mismatch regarding `vsie_page= ` modifications. -- --- Patch [7]: [PATCH 07/21] KVM: s390: vsie: Add ssca_block and ssca_entry= structs for vsie_ie --- commit 62a4a049329b153db252c516ebc9d4ec4ac9f106 Author: Christoph Schlameuss KVM: s390: vsie: Add ssca_block and ssca_entry structs for vsie_ie This commit adds the ssca_block and ssca_entry structures to represent the shadow state description and original SIGP entries. It also updates the SIE control block definition to include the original state description address. > KVM: s390: vsie: Add ssca_block and ssca_entry structs for vsie_ie > > Add the required guest-1 structures for the vsie_sigpif to the SIE > control block and vsie_page for use in later patches. [Severity: Medium] Is struct vsie_page supposed to be updated in this patch? The commit message mentions adding structures to vsie_page, but looking at arch/s390/kvm/vsie.c where struct vsie_page is defined, there are no changes to it in this diff. Could a chunk of the patch have been accidentally omitted during a rebase or patch split, or does the commit message just need to be updated to reflect the current patch boundaries? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-vsie-sigpi= -v1-0-ea9f12066408@linux.ibm.com?part=3D7