From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
patches@kernelci.org, lkft-triage@lists.linaro.org,
pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com,
sudipm.mukherjee@gmail.com, rwarsow@gmx.de, conor@kernel.org,
hargar@microsoft.com, broonie@kernel.org, achill@achill.org,
Daniel Borkmann <daniel@iogearbox.net>,
Dan Carpenter <dan.carpenter@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Anders Roxell <anders.roxell@linaro.org>,
Ben Copeland <benjamin.copeland@linaro.org>,
linux-s390@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
Date: Wed, 15 Oct 2025 15:05:35 +0200 [thread overview]
Message-ID: <21909f5d6a29819249f2b36f5e9911d593afea7c.camel@linux.ibm.com> (raw)
In-Reply-To: <2025101523-foster-impotent-6649@gregkh>
On Wed, 2025-10-15 at 10:46 +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 14, 2025 at 04:45:11PM +0200, Ilya Leoshkevich wrote:
> > On Tue, 2025-10-14 at 19:38 +0530, Naresh Kamboju wrote:
> > > On Tue, 14 Oct 2025 at 16:56, Naresh Kamboju
> > > <naresh.kamboju@linaro.org> wrote:
> > > >
> > > > On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 6.12.53
> > > > > release.
> > > > > There are 262 patches in this series, all will be posted as a
> > > > > response
> > > > > to this one. If anyone has any issues with these being
> > > > > applied,
> > > > > please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > >
> > > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> > > > > or in the git tree and branch at:
> > > > >
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
> > > > > stable-rc.git linux-6.12.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > The S390 defconfig builds failed on the Linux stable-rc
> > > > 6.12.53-rc1
> > > > and 6.6.112-rc1 tag build due to following build warnings /
> > > > errors
> > > > with gcc and clang toolchains.
> > > >
> > > > Also seen on 6.6.112-rc1.
> > > >
> > > > * s390, build
> > > > - clang-21-defconfig
> > > > - clang-nightly-defconfig
> > > > - clang-nightly-lkftconfig-hardening
> > > > - clang-nightly-lkftconfig-lto-full
> > > > - clang-nightly-lkftconfig-lto-thing
> > > > - gcc-14-allmodconfig
> > > > - gcc-14-defconfig
> > > > - gcc-14-lkftconfig-hardening
> > > > - gcc-8-defconfig-fe40093d
> > > > - gcc-8-lkftconfig-hardening
> > > > - korg-clang-21-lkftconfig-hardening
> > > > - korg-clang-21-lkftconfig-lto-full
> > > > - korg-clang-21-lkftconfig-lto-thing
> > > >
> > > > First seen on 6.12.53-rc1
> > > > Good: v6.12.52
> > > > Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
> > > >
> > > > Regression Analysis:
> > > > - New regression? yes
> > > > - Reproducibility? yes
> > > >
> > > > Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
> > > > 'struct bpf_jit' has no member named 'frame_off'
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > # Build error
> > > > arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> > > > arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit'
> > > > has
> > > > no
> > > > member named 'frame_off'
> > > > 1813 | _EMIT6(0xd203f000 | (jit-
> > > > >frame_off
> > > > +
> > > > | ^~
> > > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > > (op1); \
> > > > |
> > > > ^~~
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > > (op1); \
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 1814 |
> > > > offsetof(struct prog_frame,
> > > > | ^~~~~~~~
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4)
> > > > =
> > > > (op2); \
> > > >
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 1816 | 0xf000 | offsetof(struct
> > > > prog_frame,
> > > > | ^~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c: In function
> > > > '__arch_prepare_bpf_trampoline':
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4)
> > > > =
> > > > (op2); \
> > > >
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 2813 | 0xf000 | offsetof(struct
> > > > prog_frame,
> > > > tail_call_cnt));
> > > > | ^~~~~~~~
> > > > make[5]: *** [scripts/Makefile.build:229:
> > > > arch/s390/net/bpf_jit_comp.o] Error 1
> > > >
> > > > The git blame is pointing to,
> > > > $ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
> > > > 162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 |
> > > > (jit-
> > > > > frame_off +
> > > >
> > > > Commit pointing to,
> > > > s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
> > > > [ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
> > >
> > > Anders bisected reported regressions and also suggested the
> > > missing
> > > patches.
> > >
> > > Ilya Leoshkevich,
> > > Is it a good idea to backport / cherry pick these two patches on
> > > the
> > > 6.12 branch ?
> > >
> > > b2268d550d20 ("s390/bpf: Centralize frame offset calculations")
> > > e26d523edf2a ("s390/bpf: Describe the frame using a struct
> > > instead of
> > > constants")
> >
> > Thank you for the report and the investigation!
> >
> > I think it would be a good idea to backport these.
> > Both are NFC changes that went into v6.17 and there were no
> > complaints.
> >
> > For v6.6 we also need this one (also NFC):
> >
> > 67aed27bcd46 ("s390/bpf: Change seen_reg to a mask")
>
> Thanks for the info, I'll go drop the original offending commit from
> both queues. Can someone please resubmit all of the needed changes
> for
> us to apply so that I am sure to get them all correctly?
Will do; they require a very minor conflict resolution.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2025-10-15 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251013144326.116493600@linuxfoundation.org>
2025-10-14 11:26 ` [PATCH 6.12 000/262] 6.12.53-rc1 review Naresh Kamboju
2025-10-14 14:08 ` Naresh Kamboju
2025-10-14 14:45 ` Ilya Leoshkevich
2025-10-15 8:46 ` Greg Kroah-Hartman
2025-10-15 13:05 ` Ilya Leoshkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21909f5d6a29819249f2b36f5e9911d593afea7c.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=achill@achill.org \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=benjamin.copeland@linaro.org \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=conor@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@iogearbox.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hargar@microsoft.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).