* Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
[not found] <20251013144326.116493600@linuxfoundation.org>
@ 2025-10-14 11:26 ` Naresh Kamboju
2025-10-14 14:08 ` Naresh Kamboju
0 siblings, 1 reply; 5+ messages in thread
From: Naresh Kamboju @ 2025-10-14 11:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, rwarsow, conor, hargar, broonie, achill,
Ilya Leoshkevich, Daniel Borkmann, Dan Carpenter, Arnd Bergmann,
Anders Roxell, Ben Copeland, linux-s390, Netdev, bpf
On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.12.53 release.
> There are 262 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The S390 defconfig builds failed on the Linux stable-rc 6.12.53-rc1
and 6.6.112-rc1 tag build due to following build warnings / errors
with gcc and clang toolchains.
Also seen on 6.6.112-rc1.
* s390, build
- clang-21-defconfig
- clang-nightly-defconfig
- clang-nightly-lkftconfig-hardening
- clang-nightly-lkftconfig-lto-full
- clang-nightly-lkftconfig-lto-thing
- gcc-14-allmodconfig
- gcc-14-defconfig
- gcc-14-lkftconfig-hardening
- gcc-8-defconfig-fe40093d
- gcc-8-lkftconfig-hardening
- korg-clang-21-lkftconfig-hardening
- korg-clang-21-lkftconfig-lto-full
- korg-clang-21-lkftconfig-lto-thing
First seen on 6.12.53-rc1
Good: v6.12.52
Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
Regression Analysis:
- New regression? yes
- Reproducibility? yes
Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
'struct bpf_jit' has no member named 'frame_off'
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
# Build error
arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit' has no
member named 'frame_off'
1813 | _EMIT6(0xd203f000 | (jit->frame_off +
| ^~
arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro '_EMIT6'
211 | *(u32 *) (jit->prg_buf + jit->prg) = (op1); \
| ^~~
include/linux/stddef.h:16:33: error: invalid use of undefined type
'struct prog_frame'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~~~~~~~~~~~~~
arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro '_EMIT6'
211 | *(u32 *) (jit->prg_buf + jit->prg) = (op1); \
| ^~~
arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of macro 'offsetof'
1814 | offsetof(struct prog_frame,
| ^~~~~~~~
include/linux/stddef.h:16:33: error: invalid use of undefined type
'struct prog_frame'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~~~~~~~~~~~~~
arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro '_EMIT6'
212 | *(u16 *) (jit->prg_buf + jit->prg + 4) = (op2); \
| ^~~
arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of macro 'offsetof'
1816 | 0xf000 | offsetof(struct prog_frame,
| ^~~~~~~~
arch/s390/net/bpf_jit_comp.c: In function '__arch_prepare_bpf_trampoline':
include/linux/stddef.h:16:33: error: invalid use of undefined type
'struct prog_frame'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~~~~~~~~~~~~~
arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro '_EMIT6'
212 | *(u16 *) (jit->prg_buf + jit->prg + 4) = (op2); \
| ^~~
arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of macro 'offsetof'
2813 | 0xf000 | offsetof(struct prog_frame,
tail_call_cnt));
| ^~~~~~~~
make[5]: *** [scripts/Makefile.build:229: arch/s390/net/bpf_jit_comp.o] Error 1
The git blame is pointing to,
$ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 | (jit->frame_off +
Commit pointing to,
s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
[ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
## Build
* kernel: 6.12.53-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 7e50c0945b4ab1d4019f9905f6cf5350082c6a84
* git describe: v6.12.52-263-g7e50c0945b4a
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.52-263-g7e50c0945b4a
## Test Regressions (compared to v6.12.50-47-gf7ad21173a19)
* s390, build
- clang-21-defconfig
- clang-nightly-defconfig
- clang-nightly-lkftconfig-hardening
- clang-nightly-lkftconfig-lto-full
- clang-nightly-lkftconfig-lto-thing
- gcc-14-allmodconfig
- gcc-14-defconfig
- gcc-14-lkftconfig-hardening
- gcc-8-defconfig-fe40093d
- gcc-8-lkftconfig-hardening
- korg-clang-21-lkftconfig-hardening
- korg-clang-21-lkftconfig-lto-full
- korg-clang-21-lkftconfig-lto-thing
## Metric Regressions (compared to v6.12.50-47-gf7ad21173a19)
## Test Fixes (compared to v6.12.50-47-gf7ad21173a19)
## Metric Fixes (compared to v6.12.50-47-gf7ad21173a19)
## Test result summary
total: 152513, pass: 126770, fail: 5572, skip: 19634, xfail: 537
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 139 total, 137 passed, 2 failed
* arm64: 57 total, 51 passed, 6 failed
* i386: 18 total, 18 passed, 0 failed
* mips: 34 total, 33 passed, 1 failed
* parisc: 4 total, 4 passed, 0 failed
* powerpc: 40 total, 39 passed, 1 failed
* riscv: 25 total, 24 passed, 1 failed
* s390: 22 total, 8 passed, 14 failed
* sh: 5 total, 5 passed, 0 failed
* sparc: 4 total, 3 passed, 1 failed
* x86_64: 49 total, 46 passed, 3 failed
## Test suites summary
* boot
* commands
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mm
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* kvm-unit-tests
* lava
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
* rt-tests-cyclicdeadline
* rt-tests-pi-stress
* rt-tests-pmqtest
* rt-tests-rt-migrate-test
* rt-tests-signaltest
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
2025-10-14 11:26 ` [PATCH 6.12 000/262] 6.12.53-rc1 review Naresh Kamboju
@ 2025-10-14 14:08 ` Naresh Kamboju
2025-10-14 14:45 ` Ilya Leoshkevich
0 siblings, 1 reply; 5+ messages in thread
From: Naresh Kamboju @ 2025-10-14 14:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, rwarsow, conor, hargar, broonie, achill,
Ilya Leoshkevich, Daniel Borkmann, Dan Carpenter, Arnd Bergmann,
Anders Roxell, Ben Copeland, linux-s390, Netdev, bpf
On Tue, 14 Oct 2025 at 16:56, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.12.53 release.
> > There are 262 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.12.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> The S390 defconfig builds failed on the Linux stable-rc 6.12.53-rc1
> and 6.6.112-rc1 tag build due to following build warnings / errors
> with gcc and clang toolchains.
>
> Also seen on 6.6.112-rc1.
>
> * s390, build
> - clang-21-defconfig
> - clang-nightly-defconfig
> - clang-nightly-lkftconfig-hardening
> - clang-nightly-lkftconfig-lto-full
> - clang-nightly-lkftconfig-lto-thing
> - gcc-14-allmodconfig
> - gcc-14-defconfig
> - gcc-14-lkftconfig-hardening
> - gcc-8-defconfig-fe40093d
> - gcc-8-lkftconfig-hardening
> - korg-clang-21-lkftconfig-hardening
> - korg-clang-21-lkftconfig-lto-full
> - korg-clang-21-lkftconfig-lto-thing
>
> First seen on 6.12.53-rc1
> Good: v6.12.52
> Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
>
> Regression Analysis:
> - New regression? yes
> - Reproducibility? yes
>
> Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
> 'struct bpf_jit' has no member named 'frame_off'
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> # Build error
> arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit' has no
> member named 'frame_off'
> 1813 | _EMIT6(0xd203f000 | (jit->frame_off +
> | ^~
> arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro '_EMIT6'
> 211 | *(u32 *) (jit->prg_buf + jit->prg) = (op1); \
> | ^~~
> include/linux/stddef.h:16:33: error: invalid use of undefined type
> 'struct prog_frame'
> 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
> | ^~~~~~~~~~~~~~~~~~
> arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro '_EMIT6'
> 211 | *(u32 *) (jit->prg_buf + jit->prg) = (op1); \
> | ^~~
> arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of macro 'offsetof'
> 1814 | offsetof(struct prog_frame,
> | ^~~~~~~~
> include/linux/stddef.h:16:33: error: invalid use of undefined type
> 'struct prog_frame'
> 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
> | ^~~~~~~~~~~~~~~~~~
> arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro '_EMIT6'
> 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) = (op2); \
> | ^~~
> arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of macro 'offsetof'
> 1816 | 0xf000 | offsetof(struct prog_frame,
> | ^~~~~~~~
> arch/s390/net/bpf_jit_comp.c: In function '__arch_prepare_bpf_trampoline':
> include/linux/stddef.h:16:33: error: invalid use of undefined type
> 'struct prog_frame'
> 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
> | ^~~~~~~~~~~~~~~~~~
> arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro '_EMIT6'
> 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) = (op2); \
> | ^~~
> arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of macro 'offsetof'
> 2813 | 0xf000 | offsetof(struct prog_frame,
> tail_call_cnt));
> | ^~~~~~~~
> make[5]: *** [scripts/Makefile.build:229: arch/s390/net/bpf_jit_comp.o] Error 1
>
> The git blame is pointing to,
> $ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
> 162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 | (jit->frame_off +
>
> Commit pointing to,
> s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
> [ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
Anders bisected reported regressions and also suggested the missing patches.
Ilya Leoshkevich,
Is it a good idea to backport / cherry pick these two patches on the
6.12 branch ?
b2268d550d20 ("s390/bpf: Centralize frame offset calculations")
e26d523edf2a ("s390/bpf: Describe the frame using a struct instead of
constants")
> ## Build
> * kernel: 6.12.53-rc1
> * git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> * git commit: 7e50c0945b4ab1d4019f9905f6cf5350082c6a84
> * git describe: v6.12.52-263-g7e50c0945b4a
> * test details:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.52-263-g7e50c0945b4a
>
> ## Test Regressions (compared to v6.12.50-47-gf7ad21173a19)
> * s390, build
> - clang-21-defconfig
> - clang-nightly-defconfig
> - clang-nightly-lkftconfig-hardening
> - clang-nightly-lkftconfig-lto-full
> - clang-nightly-lkftconfig-lto-thing
> - gcc-14-allmodconfig
> - gcc-14-defconfig
> - gcc-14-lkftconfig-hardening
> - gcc-8-defconfig-fe40093d
> - gcc-8-lkftconfig-hardening
> - korg-clang-21-lkftconfig-hardening
> - korg-clang-21-lkftconfig-lto-full
> - korg-clang-21-lkftconfig-lto-thing
- Naresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
2025-10-14 14:08 ` Naresh Kamboju
@ 2025-10-14 14:45 ` Ilya Leoshkevich
2025-10-15 8:46 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Ilya Leoshkevich @ 2025-10-14 14:45 UTC (permalink / raw)
To: Naresh Kamboju, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, rwarsow, conor, hargar, broonie, achill,
Daniel Borkmann, Dan Carpenter, Arnd Bergmann, Anders Roxell,
Ben Copeland, linux-s390, Netdev, bpf
On Tue, 2025-10-14 at 19:38 +0530, Naresh Kamboju wrote:
> On Tue, 14 Oct 2025 at 16:56, Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 6.12.53
> > > release.
> > > There are 262 patches in this series, all will be posted as a
> > > response
> > > to this one. If anyone has any issues with these being applied,
> > > please
> > > let me know.
> > >
> > > Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >
> > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> > > or in the git tree and branch at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
> > > stable-rc.git linux-6.12.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > The S390 defconfig builds failed on the Linux stable-rc 6.12.53-rc1
> > and 6.6.112-rc1 tag build due to following build warnings / errors
> > with gcc and clang toolchains.
> >
> > Also seen on 6.6.112-rc1.
> >
> > * s390, build
> > - clang-21-defconfig
> > - clang-nightly-defconfig
> > - clang-nightly-lkftconfig-hardening
> > - clang-nightly-lkftconfig-lto-full
> > - clang-nightly-lkftconfig-lto-thing
> > - gcc-14-allmodconfig
> > - gcc-14-defconfig
> > - gcc-14-lkftconfig-hardening
> > - gcc-8-defconfig-fe40093d
> > - gcc-8-lkftconfig-hardening
> > - korg-clang-21-lkftconfig-hardening
> > - korg-clang-21-lkftconfig-lto-full
> > - korg-clang-21-lkftconfig-lto-thing
> >
> > First seen on 6.12.53-rc1
> > Good: v6.12.52
> > Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
> >
> > Regression Analysis:
> > - New regression? yes
> > - Reproducibility? yes
> >
> > Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
> > 'struct bpf_jit' has no member named 'frame_off'
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > # Build error
> > arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> > arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit' has
> > no
> > member named 'frame_off'
> > 1813 | _EMIT6(0xd203f000 | (jit->frame_off
> > +
> > | ^~
> > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro
> > '_EMIT6'
> > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > (op1); \
> > | ^~~
> > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > 'struct prog_frame'
> > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > MEMBER)
> > | ^~~~~~~~~~~~~~~~~~
> > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro
> > '_EMIT6'
> > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > (op1); \
> > | ^~~
> > arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of macro
> > 'offsetof'
> > 1814 |
> > offsetof(struct prog_frame,
> > | ^~~~~~~~
> > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > 'struct prog_frame'
> > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > MEMBER)
> > | ^~~~~~~~~~~~~~~~~~
> > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro
> > '_EMIT6'
> > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) =
> > (op2); \
> > |
> > ^~~
> > arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of macro
> > 'offsetof'
> > 1816 | 0xf000 | offsetof(struct
> > prog_frame,
> > | ^~~~~~~~
> > arch/s390/net/bpf_jit_comp.c: In function
> > '__arch_prepare_bpf_trampoline':
> > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > 'struct prog_frame'
> > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > MEMBER)
> > | ^~~~~~~~~~~~~~~~~~
> > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro
> > '_EMIT6'
> > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) =
> > (op2); \
> > |
> > ^~~
> > arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of macro
> > 'offsetof'
> > 2813 | 0xf000 | offsetof(struct prog_frame,
> > tail_call_cnt));
> > | ^~~~~~~~
> > make[5]: *** [scripts/Makefile.build:229:
> > arch/s390/net/bpf_jit_comp.o] Error 1
> >
> > The git blame is pointing to,
> > $ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
> > 162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 | (jit-
> > >frame_off +
> >
> > Commit pointing to,
> > s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
> > [ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
>
> Anders bisected reported regressions and also suggested the missing
> patches.
>
> Ilya Leoshkevich,
> Is it a good idea to backport / cherry pick these two patches on the
> 6.12 branch ?
>
> b2268d550d20 ("s390/bpf: Centralize frame offset calculations")
> e26d523edf2a ("s390/bpf: Describe the frame using a struct instead of
> constants")
Thank you for the report and the investigation!
I think it would be a good idea to backport these.
Both are NFC changes that went into v6.17 and there were no complaints.
For v6.6 we also need this one (also NFC):
67aed27bcd46 ("s390/bpf: Change seen_reg to a mask")
> > ## Build
> > * kernel: 6.12.53-rc1
> > * git:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > * git commit: 7e50c0945b4ab1d4019f9905f6cf5350082c6a84
> > * git describe: v6.12.52-263-g7e50c0945b4a
> > * test details:
> > https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.12.y/build/v6.12.52-263-g7e50c0945b4a
> >
> > ## Test Regressions (compared to v6.12.50-47-gf7ad21173a19)
> > * s390, build
> > - clang-21-defconfig
> > - clang-nightly-defconfig
> > - clang-nightly-lkftconfig-hardening
> > - clang-nightly-lkftconfig-lto-full
> > - clang-nightly-lkftconfig-lto-thing
> > - gcc-14-allmodconfig
> > - gcc-14-defconfig
> > - gcc-14-lkftconfig-hardening
> > - gcc-8-defconfig-fe40093d
> > - gcc-8-lkftconfig-hardening
> > - korg-clang-21-lkftconfig-hardening
> > - korg-clang-21-lkftconfig-lto-full
> > - korg-clang-21-lkftconfig-lto-thing
>
> - Naresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
2025-10-14 14:45 ` Ilya Leoshkevich
@ 2025-10-15 8:46 ` Greg Kroah-Hartman
2025-10-15 13:05 ` Ilya Leoshkevich
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2025-10-15 8:46 UTC (permalink / raw)
To: Ilya Leoshkevich
Cc: Naresh Kamboju, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, rwarsow, conor, hargar, broonie, achill,
Daniel Borkmann, Dan Carpenter, Arnd Bergmann, Anders Roxell,
Ben Copeland, linux-s390, Netdev, bpf
On Tue, Oct 14, 2025 at 04:45:11PM +0200, Ilya Leoshkevich wrote:
> On Tue, 2025-10-14 at 19:38 +0530, Naresh Kamboju wrote:
> > On Tue, 14 Oct 2025 at 16:56, Naresh Kamboju
> > <naresh.kamboju@linaro.org> wrote:
> > >
> > > On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 6.12.53
> > > > release.
> > > > There are 262 patches in this series, all will be posted as a
> > > > response
> > > > to this one. If anyone has any issues with these being applied,
> > > > please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >
> > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> > > > or in the git tree and branch at:
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
> > > > stable-rc.git linux-6.12.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > The S390 defconfig builds failed on the Linux stable-rc 6.12.53-rc1
> > > and 6.6.112-rc1 tag build due to following build warnings / errors
> > > with gcc and clang toolchains.
> > >
> > > Also seen on 6.6.112-rc1.
> > >
> > > * s390, build
> > > - clang-21-defconfig
> > > - clang-nightly-defconfig
> > > - clang-nightly-lkftconfig-hardening
> > > - clang-nightly-lkftconfig-lto-full
> > > - clang-nightly-lkftconfig-lto-thing
> > > - gcc-14-allmodconfig
> > > - gcc-14-defconfig
> > > - gcc-14-lkftconfig-hardening
> > > - gcc-8-defconfig-fe40093d
> > > - gcc-8-lkftconfig-hardening
> > > - korg-clang-21-lkftconfig-hardening
> > > - korg-clang-21-lkftconfig-lto-full
> > > - korg-clang-21-lkftconfig-lto-thing
> > >
> > > First seen on 6.12.53-rc1
> > > Good: v6.12.52
> > > Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
> > >
> > > Regression Analysis:
> > > - New regression? yes
> > > - Reproducibility? yes
> > >
> > > Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
> > > 'struct bpf_jit' has no member named 'frame_off'
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > # Build error
> > > arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> > > arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit' has
> > > no
> > > member named 'frame_off'
> > > 1813 | _EMIT6(0xd203f000 | (jit->frame_off
> > > +
> > > | ^~
> > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro
> > > '_EMIT6'
> > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > (op1); \
> > > | ^~~
> > > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > > 'struct prog_frame'
> > > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > > MEMBER)
> > > | ^~~~~~~~~~~~~~~~~~
> > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of macro
> > > '_EMIT6'
> > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > (op1); \
> > > | ^~~
> > > arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of macro
> > > 'offsetof'
> > > 1814 |
> > > offsetof(struct prog_frame,
> > > | ^~~~~~~~
> > > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > > 'struct prog_frame'
> > > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > > MEMBER)
> > > | ^~~~~~~~~~~~~~~~~~
> > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro
> > > '_EMIT6'
> > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) =
> > > (op2); \
> > > |
> > > ^~~
> > > arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of macro
> > > 'offsetof'
> > > 1816 | 0xf000 | offsetof(struct
> > > prog_frame,
> > > | ^~~~~~~~
> > > arch/s390/net/bpf_jit_comp.c: In function
> > > '__arch_prepare_bpf_trampoline':
> > > include/linux/stddef.h:16:33: error: invalid use of undefined type
> > > 'struct prog_frame'
> > > 16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE,
> > > MEMBER)
> > > | ^~~~~~~~~~~~~~~~~~
> > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of macro
> > > '_EMIT6'
> > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4) =
> > > (op2); \
> > > |
> > > ^~~
> > > arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of macro
> > > 'offsetof'
> > > 2813 | 0xf000 | offsetof(struct prog_frame,
> > > tail_call_cnt));
> > > | ^~~~~~~~
> > > make[5]: *** [scripts/Makefile.build:229:
> > > arch/s390/net/bpf_jit_comp.o] Error 1
> > >
> > > The git blame is pointing to,
> > > $ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
> > > 162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 | (jit-
> > > >frame_off +
> > >
> > > Commit pointing to,
> > > s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
> > > [ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
> >
> > Anders bisected reported regressions and also suggested the missing
> > patches.
> >
> > Ilya Leoshkevich,
> > Is it a good idea to backport / cherry pick these two patches on the
> > 6.12 branch ?
> >
> > b2268d550d20 ("s390/bpf: Centralize frame offset calculations")
> > e26d523edf2a ("s390/bpf: Describe the frame using a struct instead of
> > constants")
>
> Thank you for the report and the investigation!
>
> I think it would be a good idea to backport these.
> Both are NFC changes that went into v6.17 and there were no complaints.
>
> For v6.6 we also need this one (also NFC):
>
> 67aed27bcd46 ("s390/bpf: Change seen_reg to a mask")
Thanks for the info, I'll go drop the original offending commit from
both queues. Can someone please resubmit all of the needed changes for
us to apply so that I am sure to get them all correctly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6.12 000/262] 6.12.53-rc1 review
2025-10-15 8:46 ` Greg Kroah-Hartman
@ 2025-10-15 13:05 ` Ilya Leoshkevich
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Leoshkevich @ 2025-10-15 13:05 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Naresh Kamboju, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, rwarsow, conor, hargar, broonie, achill,
Daniel Borkmann, Dan Carpenter, Arnd Bergmann, Anders Roxell,
Ben Copeland, linux-s390, Netdev, bpf
On Wed, 2025-10-15 at 10:46 +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 14, 2025 at 04:45:11PM +0200, Ilya Leoshkevich wrote:
> > On Tue, 2025-10-14 at 19:38 +0530, Naresh Kamboju wrote:
> > > On Tue, 14 Oct 2025 at 16:56, Naresh Kamboju
> > > <naresh.kamboju@linaro.org> wrote:
> > > >
> > > > On Mon, 13 Oct 2025 at 20:38, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 6.12.53
> > > > > release.
> > > > > There are 262 patches in this series, all will be posted as a
> > > > > response
> > > > > to this one. If anyone has any issues with these being
> > > > > applied,
> > > > > please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 15 Oct 2025 14:42:41 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > >
> > > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.12.53-rc1.gz
> > > > > or in the git tree and branch at:
> > > > >
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
> > > > > stable-rc.git linux-6.12.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > The S390 defconfig builds failed on the Linux stable-rc
> > > > 6.12.53-rc1
> > > > and 6.6.112-rc1 tag build due to following build warnings /
> > > > errors
> > > > with gcc and clang toolchains.
> > > >
> > > > Also seen on 6.6.112-rc1.
> > > >
> > > > * s390, build
> > > > - clang-21-defconfig
> > > > - clang-nightly-defconfig
> > > > - clang-nightly-lkftconfig-hardening
> > > > - clang-nightly-lkftconfig-lto-full
> > > > - clang-nightly-lkftconfig-lto-thing
> > > > - gcc-14-allmodconfig
> > > > - gcc-14-defconfig
> > > > - gcc-14-lkftconfig-hardening
> > > > - gcc-8-defconfig-fe40093d
> > > > - gcc-8-lkftconfig-hardening
> > > > - korg-clang-21-lkftconfig-hardening
> > > > - korg-clang-21-lkftconfig-lto-full
> > > > - korg-clang-21-lkftconfig-lto-thing
> > > >
> > > > First seen on 6.12.53-rc1
> > > > Good: v6.12.52
> > > > Bad: 6.12.53-rc1 also seen on 6.6.112-rc1
> > > >
> > > > Regression Analysis:
> > > > - New regression? yes
> > > > - Reproducibility? yes
> > > >
> > > > Build regressions: arch/s390/net/bpf_jit_comp.c:1813:49: error:
> > > > 'struct bpf_jit' has no member named 'frame_off'
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > # Build error
> > > > arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> > > > arch/s390/net/bpf_jit_comp.c:1813:49: error: 'struct bpf_jit'
> > > > has
> > > > no
> > > > member named 'frame_off'
> > > > 1813 | _EMIT6(0xd203f000 | (jit-
> > > > >frame_off
> > > > +
> > > > | ^~
> > > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > > (op1); \
> > > > |
> > > > ^~~
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:211:55: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 211 | *(u32 *) (jit->prg_buf + jit->prg) =
> > > > (op1); \
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:1814:46: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 1814 |
> > > > offsetof(struct prog_frame,
> > > > | ^~~~~~~~
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4)
> > > > =
> > > > (op2); \
> > > >
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:1816:41: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 1816 | 0xf000 | offsetof(struct
> > > > prog_frame,
> > > > | ^~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c: In function
> > > > '__arch_prepare_bpf_trampoline':
> > > > include/linux/stddef.h:16:33: error: invalid use of undefined
> > > > type
> > > > 'struct prog_frame'
> > > > 16 | #define offsetof(TYPE, MEMBER)
> > > > __builtin_offsetof(TYPE,
> > > > MEMBER)
> > > > | ^~~~~~~~~~~~~~~~~~
> > > > arch/s390/net/bpf_jit_comp.c:212:59: note: in definition of
> > > > macro
> > > > '_EMIT6'
> > > > 212 | *(u16 *) (jit->prg_buf + jit->prg + 4)
> > > > =
> > > > (op2); \
> > > >
> > > > |
> > > > ^~~
> > > > arch/s390/net/bpf_jit_comp.c:2813:33: note: in expansion of
> > > > macro
> > > > 'offsetof'
> > > > 2813 | 0xf000 | offsetof(struct
> > > > prog_frame,
> > > > tail_call_cnt));
> > > > | ^~~~~~~~
> > > > make[5]: *** [scripts/Makefile.build:229:
> > > > arch/s390/net/bpf_jit_comp.o] Error 1
> > > >
> > > > The git blame is pointing to,
> > > > $ git blame -L 1813 arch/s390/net/bpf_jit_comp.c
> > > > 162513d7d81487 (Ilya Leoshkevich) _EMIT6(0xd203f000 |
> > > > (jit-
> > > > > frame_off +
> > > >
> > > > Commit pointing to,
> > > > s390/bpf: Write back tail call counter for BPF_PSEUDO_CALL
> > > > [ Upstream commit c861a6b147137d10b5ff88a2c492ba376cd1b8b0 ]
> > >
> > > Anders bisected reported regressions and also suggested the
> > > missing
> > > patches.
> > >
> > > Ilya Leoshkevich,
> > > Is it a good idea to backport / cherry pick these two patches on
> > > the
> > > 6.12 branch ?
> > >
> > > b2268d550d20 ("s390/bpf: Centralize frame offset calculations")
> > > e26d523edf2a ("s390/bpf: Describe the frame using a struct
> > > instead of
> > > constants")
> >
> > Thank you for the report and the investigation!
> >
> > I think it would be a good idea to backport these.
> > Both are NFC changes that went into v6.17 and there were no
> > complaints.
> >
> > For v6.6 we also need this one (also NFC):
> >
> > 67aed27bcd46 ("s390/bpf: Change seen_reg to a mask")
>
> Thanks for the info, I'll go drop the original offending commit from
> both queues. Can someone please resubmit all of the needed changes
> for
> us to apply so that I am sure to get them all correctly?
Will do; they require a very minor conflict resolution.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-15 13:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251013144326.116493600@linuxfoundation.org>
2025-10-14 11:26 ` [PATCH 6.12 000/262] 6.12.53-rc1 review Naresh Kamboju
2025-10-14 14:08 ` Naresh Kamboju
2025-10-14 14:45 ` Ilya Leoshkevich
2025-10-15 8:46 ` Greg Kroah-Hartman
2025-10-15 13:05 ` Ilya Leoshkevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).