From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:24594 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729240AbfLENQI (ORCPT ); Thu, 5 Dec 2019 08:16:08 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB5D7lL2029497 for ; Thu, 5 Dec 2019 08:16:07 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wpur3yc8f-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 05 Dec 2019 08:16:07 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Dec 2019 13:16:05 -0000 Subject: Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups References: <20191205125147.229367-1-borntraeger@de.ibm.com> <087b1693-6ec0-94e3-d94a-f55c2e717438@redhat.com> From: Christian Borntraeger Date: Thu, 5 Dec 2019 14:16:02 +0100 MIME-Version: 1.0 In-Reply-To: <087b1693-6ec0-94e3-d94a-f55c2e717438@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <26f905be-3f09-3b3b-3008-ef64fc93e36c@de.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thomas Huth , Janosch Frank Cc: KVM , Cornelia Huck , David Hildenbrand , linux-s390 , Julian Wiedmann On 05.12.19 14:09, Thomas Huth wrote: > On 05/12/2019 13.51, Christian Borntraeger wrote: >> There is no ENOTSUPP for userspace >> >> Reported-by: Julian Wiedmann >> Signed-off-by: Christian Borntraeger >> --- >> arch/s390/kvm/interrupt.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c >> index 2a711bae69a7..bd9b339bbb5e 100644 >> --- a/arch/s390/kvm/interrupt.c >> +++ b/arch/s390/kvm/interrupt.c >> @@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr) >> return -EINVAL; >> >> if (!test_kvm_facility(kvm, 72)) >> - return -ENOTSUPP; >> + return -EOPNOTSUPP; >> >> mutex_lock(&fi->ais_lock); >> ais.simm = fi->simm; >> @@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr) >> int ret = 0; >> >> if (!test_kvm_facility(kvm, 72)) >> - return -ENOTSUPP; >> + return -EOPNOTSUPP; >> >> if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req))) >> return -EFAULT; >> @@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr) >> struct kvm_s390_ais_all ais; >> >> if (!test_kvm_facility(kvm, 72)) >> - return -ENOTSUPP; >> + return -EOPNOTSUPP; >> >> if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais))) >> return -EFAULT; >> > > Good catch. > > Reviewed-by: Thomas Huth > > There seems to be another one in arch/s390/include/asm/uv.h, are you > going to fix that, too? > I looked into that but it seemed that this is not exposed to userspace and just kept internal.