Re: [PATCH v6 10/14] KVM: s390: Refactor absolute vm mem_op function

Janosch Frank
2023-01-26T13:03:05Z

On 1/26/23 13:18, Thomas Huth wrote:
> On 25/01/2023 22.26, Janis Schoetterl-Glausch wrote:
>> Remove code duplication with regards to the CHECK_ONLY flag.
>> Decrease the number of indents.
>> No functional change indented.
>>
>> Suggested-by: Janosch Frank <frankja@linux.ibm.com>
>> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
>> ---
>>
>>
>> Cosmetic only, can be dropped.
>
> I'm torn between unnecessary-code-churn and
> nice-to-get-rid-of-one-indentation-level here ... anyway, patch looks sane
> to me, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>

As long as we're not adding to this function in the future then I'm
okish with leaving it as is.