From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B08CE229B36 for ; Mon, 7 Apr 2025 08:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744013838; cv=none; b=fTR39EJ/bX4EZmzh7O4RqgAfOGLaN/Jnuwie1zzSH55lC2Vtg9r4RAieivP5MCQViVBuJhCBRticaKDDPpgichSX8v5MhYrXaaDzai8AmzwEumWxyAv+r+3x2g8lStCpHDr44yYtwryhtbSIfULO7iCAs6gIvz7C9OS4DIBB9nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744013838; c=relaxed/simple; bh=6i1f3CKo9PEyCnkVhJmw/jWgRJzLssW0mmYmutlUE40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VSSDJuXyPaOmx5726Pw8pLoNTXZ/zopCjve/b9o53pYV/vtZSY0y/RrXCbRlle7xyDaj0bUJbZb6WnRE/+IQHUOTvnp4DGOo8j/G+EQ6waAhdSM9MiLMjNY8SJ/pQwO7ID+noZ+JVD2Ak6smweXBPoW0xJvzusAabt4LIao11Qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bywhBrMi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bywhBrMi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744013835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T902koP+vDQhe09LsDigsq4SLe6sGI8phT+3dNyxQbM=; b=bywhBrMiJO5W7LNaAufR6IFUT2WlgymsBU5K5tRVjM3EoUb/RtQdJLXnS6MVLEwT2NB8// 3G4oWgQPnKo0kmFiUvw6bjTtu5OV035jO3cULLjnv+aSqB70ICjpt/XN3Jw/AFtF1Hn2Bf EaNJqe60hUx14dOpurNwElO4/2gd794= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-CxjgtW_VONKPJpKtjIvEgw-1; Mon, 07 Apr 2025 04:17:14 -0400 X-MC-Unique: CxjgtW_VONKPJpKtjIvEgw-1 X-Mimecast-MFC-AGG-ID: CxjgtW_VONKPJpKtjIvEgw_1744013833 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-391315098b2so1652136f8f.2 for ; Mon, 07 Apr 2025 01:17:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744013833; x=1744618633; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T902koP+vDQhe09LsDigsq4SLe6sGI8phT+3dNyxQbM=; b=jdT67z1xFPxuuXru/77VZKSPN+6A86vGJdIvZzrRiB446Kl8xbszVvXY6aDRfyJq/I YPLZK7M75XGSl+E2n4i8sitdq97NH5jtvIjIxDFDFTrI0bvsu8kbHo9R7JminoO3SNWz GAoHp2BZJ3b4/rTlnjfFpvMqY/b/c63fexti6Byb2bBJW3QBOvfATF7cNge/5Yby1ZzR msvrIXtfTgz0N8XoxetXQVUgVAVOc2pMzxtgpR4sppI0NEz7I2f+IkkO55gskIFMfn7d v1btdexBx/ZCDtEOhcqo81/MlTfzC8eyVGT9zjV+pPFkHaM8yXBIMhl8B2wNNYx21MPf ktfA== X-Forwarded-Encrypted: i=1; AJvYcCWF6ePiS2W/IciDPMb94ceKKxFXRsDfJfMsG8m9mBXiUrXbogCyR+J5672ovLI44JgrrsMPBcuebntT@vger.kernel.org X-Gm-Message-State: AOJu0Yx8Bls0o/HbWvHWB3iTWAWnkanIRMsB/uZKjrOKzMtVwYthIwB4 MZEjZeFGD8miQs+HbY+DvH+1zV5l+S9DECpqvUNmDoBr2vfD8kf7IkkS2ehuU8rkLE0RHA5xlOH NQrJZ+Sj8QeksVfSMY6fQcn0AEalSNXzdM+iflUC8VOT9sc2m2kZ2X5mzMIU= X-Gm-Gg: ASbGnctJsUWkcndy8rNLFvAIRcp/pkahIe7dY//X4sAdux7tI8cPqtKzgyX//xKGsR1 hz0JZiKIJqklQFhMFPFpL/4tHD8YFbYZORu1mMWPcADFlGtq8GC+3BRKiGpKbKllhsHysDwf0td MVrQMXHlaKwDSF45aHPfP/r04JYauUZ3LfDB4PPqlDQRf11KW46PpgqTAfCZNLpQBqRj9IhHFii 2DizlCtZCikfAdGAABufFStvF9BzmfxmnBKQmhnVKxmnYdZpoaUfVqOhhg85vq3fPAAwqHVoESc CRr5E561i77Gw/PKcK014mzf6zkXc8sHNr3FWPyBT2BgIFrfeRhAKpaX8OYk/zTPIMGGu92D9vF tOVDsNdr3HFegmVlPBTlNGWtgskFkoEJKnghQ/oeYR0M= X-Received: by 2002:a05:6000:2508:b0:39a:c6c1:3408 with SMTP id ffacd0b85a97d-39cba934e36mr8096802f8f.37.1744013832977; Mon, 07 Apr 2025 01:17:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYTPyDocASbSK2MVKpfBqfWpXbp45i8db41ui9sKtho+e796eDBvNjWbBPrTR31oqxV9/tYw== X-Received: by 2002:a05:6000:2508:b0:39a:c6c1:3408 with SMTP id ffacd0b85a97d-39cba934e36mr8096776f8f.37.1744013832630; Mon, 07 Apr 2025 01:17:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:3c00:8b01:4fd9:b833:e1e9? (p200300cbc7383c008b014fd9b833e1e9.dip0.t-ipconnect.de. [2003:cb:c738:3c00:8b01:4fd9:b833:e1e9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec17b1352sm123617835e9.37.2025.04.07.01.17.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Apr 2025 01:17:12 -0700 (PDT) Message-ID: <2b187710-329d-4d36-b2e7-158709ea60d6@redhat.com> Date: Mon, 7 Apr 2025 10:17:10 +0200 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues To: "Michael S. Tsirkin" , Halil Pasic Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, Chandra Merla , Stable@vger.kernel.org, Cornelia Huck , Thomas Huth , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Wei Wang References: <20250403161836.7fe9fea5.pasic@linux.ibm.com> <20250404063619.0fa60a41.pasic@linux.ibm.com> <4a33daa3-7415-411e-a491-07635e3cfdc4@redhat.com> <20250404153620.04d2df05.pasic@linux.ibm.com> <20250404160025.3ab56f60.pasic@linux.ibm.com> <6f548b8b-8c6e-4221-a5d5-8e7a9013f9c3@redhat.com> <20250404173910.6581706a.pasic@linux.ibm.com> <20250407034901-mutt-send-email-mst@kernel.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250407034901-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.04.25 09:52, Michael S. Tsirkin wrote: > On Fri, Apr 04, 2025 at 05:39:10PM +0200, Halil Pasic wrote: >>> >>> Not perfect, but AFAIKS, not horrible. >> >> It is like it is. QEMU does queue exist if the corresponding feature >> is offered by the device, and that is what we have to live with. > > I don't think we can live with this properly though. > It means a guest that does not know about some features > does not know where to find things. Please describe a real scenario, I'm missing the point. Whoever adds new feat_X *must be aware* about all previous features, otherwise we'd be reusing feature bits and everything falls to pieces. > > So now, I am inclined to add linux code to work with current qemu and > with spec compliant one, and add qemu code to work with current linux > and spec compliant one. > > Document the bug in the spec, maybe, in a non conformance section. I'm afraid this results in a lot of churn without really making things better. IMHO, documenting things how they actually behave, and maybe moving towards fixed queue indexes for new features is the low hanging fruit. As raised, it's not just qemu+linux, it's *at least* also cloud-hypervisor. -- Cheers, David / dhildenb