Re: [PATCH net 1/2] net/smc: don't send CDC/LLC message if link not ready

Karsten Graul
2021-12-29T12:36:14Z

On 28/12/2021 10:03, Dust Li wrote:
> We found smc_llc_send_link_delete_all() sometimes wait
> for 2s timeout when testing with RDMA link up/down.
> It is possible when a smc_link is in ACTIVATING state,
> the underlaying QP is still in RESET or RTR state, which
> cannot send any messages out.

I see your point, but why do you needed to introduce a new wrapper instead of
extending the existing smc_link_usable() wrapper?
With that and without any comments the reader of the code does not know why there are
2 different functions and what is the reason for having two of them.