Re: [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

Cornelia Huck
2019-04-08T17:07:47Z

On Mon, 8 Apr 2019 13:02:12 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> On 03/01/2019 04:38 AM, Cornelia Huck wrote:
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call the cp accessors in
> > any case, so we can call them unconditionally.
> >
> > While at it, also make sure that functions called from other parts
> > of the code return gracefully if the channel program structure
> > has not been initialized (even though that is a bug in the caller).
> >
> > Reviewed-by: Eric Farman<farman@linux.ibm.com>
> > Signed-off-by: Cornelia Huck<cohuck@redhat.com>
> > ---
>
> Hi Connie,
>
> My series of fixes for vfio-ccw depends on this patch as I would like to
> call cp_free unconditionally :) (I had developed my code on top of your
> patches).
>
> Could we pick this patch up as well when/if you pick up my patch series?
> I am in the process of sending out a v2.
>
> Regarding this patch we could merge it as a stand alone patch, separate
> from this series. And also the patch LGTM
>
> Reviewed-by: Farhan Ali <alifm@linux.ibm.com>

Actually, I wanted to ask how people felt about merging this whole
series for the next release :) It would be one thing less on my plate...