From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052F3C7EE21 for ; Thu, 4 May 2023 06:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbjEDGWW (ORCPT ); Thu, 4 May 2023 02:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjEDGWV (ORCPT ); Thu, 4 May 2023 02:22:21 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E415D199E; Wed, 3 May 2023 23:22:09 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R541e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=guwen@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0Vhe9zcQ_1683181325; Received: from 30.221.129.60(mailfrom:guwen@linux.alibaba.com fp:SMTPD_---0Vhe9zcQ_1683181325) by smtp.aliyun-inc.com; Thu, 04 May 2023 14:22:06 +0800 Message-ID: <38151aa1-10f4-9104-1b92-640e153d39da@linux.alibaba.com> Date: Thu, 4 May 2023 14:22:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH net-next v5 2/9] net/smc: Decouple ism_dev from SMC-D DMB registration To: Simon Horman Cc: kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1682252271-2544-1-git-send-email-guwen@linux.alibaba.com> <1682252271-2544-3-git-send-email-guwen@linux.alibaba.com> From: Wen Gu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 2023/4/28 22:40, Simon Horman wrote: > On Sun, Apr 23, 2023 at 08:17:44PM +0800, Wen Gu wrote: >> This patch tries to decouple ISM device from SMC-D DMB registration, >> So that the register_dmb option is not restricted to be used by ISM >> device. >> >> Signed-off-by: Wen Gu >> --- >> drivers/s390/net/ism_drv.c | 5 +++-- >> include/net/smc.h | 4 ++-- >> net/smc/smc_ism.c | 7 ++----- >> 3 files changed, 7 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/s390/net/ism_drv.c b/drivers/s390/net/ism_drv.c >> index 8acb9eb..5eeb54d 100644 >> --- a/drivers/s390/net/ism_drv.c >> +++ b/drivers/s390/net/ism_drv.c >> @@ -796,9 +796,10 @@ static int smcd_query_rgid(struct smcd_dev *smcd, u64 rgid, u32 vid_valid, >> } >> >> static int smcd_register_dmb(struct smcd_dev *smcd, struct smcd_dmb *dmb, >> - struct ism_client *client) >> + void *client_priv) >> { >> - return ism_register_dmb(smcd->priv, (struct ism_dmb *)dmb, client); >> + return ism_register_dmb(smcd->priv, (struct ism_dmb *)dmb, >> + (struct ism_client *)client_priv); > > Hi Wen Gu, > > a minor nit from my side: there is no need to cast a void pointer to > another type. > >> } >> >> static int smcd_unregister_dmb(struct smcd_dev *smcd, struct smcd_dmb *dmb) > > ... Hi Simon Horman, Thanks for your review and suggestions in this patch and others. I will take them in the next version. Thanks! Wen Gu