From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbhAYScG (ORCPT ); Mon, 25 Jan 2021 13:32:06 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C899C06174A for ; Mon, 25 Jan 2021 10:31:26 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id jx18so124753pjb.5 for ; Mon, 25 Jan 2021 10:31:26 -0800 (PST) Subject: Re: [PATCH 05/10] block: do not reassig ->bi_bdev when partition remapping References: <20210124100241.1167849-1-hch@lst.de> <20210124100241.1167849-6-hch@lst.de> <20210125175528.GA13451@lst.de> <2b600368-96fa-7caf-f05b-321de616f7c9@kernel.dk> <13667b22-029b-d7be-02da-96fce22cfd8f@kernel.dk> <20210125181349.GA14432@lst.de> <1c0fabdc-9b73-dfd7-f49d-c211d58cbf12@kernel.dk> <20210125181826.GA14957@lst.de> <22e0f687-3165-e9d1-e1bd-9769a11dc0ea@kernel.dk> <20210125182150.GA15367@lst.de> From: Jens Axboe Message-ID: <387c824a-c713-a087-2f6f-434ba127b1df@kernel.dk> Date: Mon, 25 Jan 2021 11:31:23 -0700 MIME-Version: 1.0 In-Reply-To: <20210125182150.GA15367@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Christoph Hellwig Cc: Tejun Heo , Coly Li , Song Liu , device-mapper development , linux-bcache , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" , linux-s390 , linux-block On 1/25/21 11:21 AM, Christoph Hellwig wrote: > On Mon, Jan 25, 2021 at 11:19:23AM -0700, Jens Axboe wrote: >> On 1/25/21 11:18 AM, Christoph Hellwig wrote: >>> On Mon, Jan 25, 2021 at 11:15:04AM -0700, Jens Axboe wrote: >>>> On 1/25/21 11:13 AM, Christoph Hellwig wrote: >>>>> On Mon, Jan 25, 2021 at 11:03:24AM -0700, Jens Axboe wrote: >>>>>> Partition table entries are not in disk order. >>>>> >>>>> And the issue shows up with the series just up to the this patch, >>>>> without any later patches? >>>> >>>> At that patch specifically. I bisected it, and then I double checked >>>> by running the previous commit (boots fine), then apply this one, and >>>> then I run into that error. So it should be 100% reliable. >>> >>> Ok, I have an idea. With EOD message you mean this printk, right: >>> >>> pr_info_ratelimited("attempt to access beyond end of device\n" >>> "%s: rw=%d, want=%llu, limit=%llu\n", >>> ... >>> >>> right? >> >> Yep > > Can you give this untested patch a spin? This should fix the > case where we check the eod for the original partition with the > remapped bi_sectors. Looking into a local reproducer now. Yep, with that applied on top my laptop boots again. -- Jens Axboe