Re: [PATCH] net/smc: fix wrong comparation in smc_pnet_add_pnetid

Gerd Bayer
2024-10-14T06:43:53Z

Hi Li RongQing,

On Mon, 2024-10-14 at 13:41 +0800, D. Wythe wrote:
> On 10/11/24 2:19 PM, Li RongQing wrote:
> > pnetid of pi (not newly allocated pe) should be compared
> >
> > Fixes: e888a2e8337c ("net/smc: introduce list of pnetids for
> > Ethernet devices")
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
> > ---
> >   net/smc/smc_pnet.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
> > index 1dd3623..a04aa0e 100644
> > --- a/net/smc/smc_pnet.c
> > +++ b/net/smc/smc_pnet.c
> > @@ -753,7 +753,7 @@ static int smc_pnet_add_pnetid(struct net *net,
> > u8 *pnetid)
> >
> >    write_lock(&sn->pnetids_ndev.lock);
> >    list_for_each_entry(pi, &sn->pnetids_ndev.list, list) {
> > - if (smc_pnet_match(pnetid, pe->pnetid)) {
> > + if (smc_pnet_match(pnetid, pi->pnetid)) {
> >    refcount_inc(&pi->refcnt);
> >    kfree(pe);
> >    goto unlock;
>
> Reviewed-by: D. Wythe <alibuda@linux.alibaba.com>
>
> Thanks,
> D. Wythe
>

Good catch, indeed!

Is this intentionally discussed off-list?
For consideration by netdev maintainers this will have to be re-
submitted with a [PATCH net] prefix to the netdev mailing list.

Also, I'd prefer, if you could find a more descriptive subject. How
about: "Fix search in list of known pnetids"? However, if you want to
keep the subject please replace "comparation" with "comparison"

Thank you,
Gerd Bayer