Re: [PATCH] KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default

Cornelia Huck
2017-09-26T11:10:52Z

On Tue, 26 Sep 2017 13:04:03 +0200
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Tue, Sep 26, 2017 at 12:57:26PM +0200, Thomas Huth wrote:
> > On 26.09.2017 12:47, Heiko Carstens wrote:
> > > So it's going to be removed with the next merge window.
> > > Where is the patch? ;)
> >
> > Hmm, so far the code was always enabled by default, so in the unlikely
> > case that somebody is still using it, they might not have noticed that
> > this is marked as deprecated. So maybe it's better to keep the code for
> > two more released, but disable it by default, so that people have time
> > to realize that it is going away? ... just my 0.02 € ... but if you
> > prefer, I can also write a patch that removes it immediately instead.
>
> Switching the default from yes to no won't prevent anybody from selecting
> it again. So I don't see any value in waiting even longer.
>
> Besides the original commit already printed a message to the console that
> the transport is deprecated.
> See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport").
>

Would ack a removal as well.