Re: [PATCH v6 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch

Alexander Gordeev
2024-01-19T13:11:20Z

On Fri, Jan 12, 2024 at 02:43:51PM -0300, Marcos Paulo de Souza wrote:
Hi Marcos,
...
> arch/s390/configs/debug_defconfig | 1 -
> arch/s390/configs/defconfig | 1 -
> lib/Kconfig.debug | 22 ----------
...
> diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
> index 85490d9373fc..5948afeeb56c 100644
> --- a/arch/s390/configs/debug_defconfig
> +++ b/arch/s390/configs/debug_defconfig
> @@ -884,4 +884,3 @@ CONFIG_ATOMIC64_SELFTEST=y
> CONFIG_STRING_SELFTEST=y
> CONFIG_TEST_BITOPS=m
> CONFIG_TEST_BPF=m
> -CONFIG_TEST_LIVEPATCH=m
> diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
> index fb690fbbf54b..8d8c2989b6fe 100644
> --- a/arch/s390/configs/defconfig
> +++ b/arch/s390/configs/defconfig
> @@ -813,4 +813,3 @@ CONFIG_KPROBES_SANITY_TEST=m
> CONFIG_PERCPU_TEST=m
> CONFIG_ATOMIC64_SELFTEST=y
> CONFIG_TEST_BPF=m
> -CONFIG_TEST_LIVEPATCH=m
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 97ce28f4d154..c2147caa7da2 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2853,28 +2853,6 @@ config TEST_MEMCAT_P
>
> If unsure, say N.
>
> -config TEST_LIVEPATCH
> - tristate "Test livepatching"
> - default n
> - depends on DYNAMIC_DEBUG
> - depends on LIVEPATCH
> - depends on m
> - help
> - Test kernel livepatching features for correctness. The tests will
> - load test modules that will be livepatched in various scenarios.
> -
> - To run all the livepatching tests:
> -
> - make -C tools/testing/selftests TARGETS=livepatch run_tests
> -
> - Alternatively, individual tests may be invoked:
> -
> - tools/testing/selftests/livepatch/test-callbacks.sh
> - tools/testing/selftests/livepatch/test-livepatch.sh
> - tools/testing/selftests/livepatch/test-shadow-vars.sh
> -
> - If unsure, say N.
> -
> config TEST_OBJAGG
> tristate "Perform selftest on object aggreration manager"
> default n

FWIW, for s390 part:

Alexander Gordeev <agordeev@linux.ibm.com>

Thanks!