Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP

Guangguan Wang
2022-06-30T14:36:57Z

On 2022/6/30 04:09, Wenjia Zhang wrote:
>
> Since Karsten's suggestion, we didn't hear from you any more. We just want to know:
>
> - What do you think about the commit (86434744)? Could it be the trigger of the problem you met?
>
> - Have you ever tried to just remove the following lines from smc_connection(), and check if your scenario could run correctly?
>
> if (smc->use_fallback)
>               goto out;
>
> In our opinion, we don't see the necessity of the patch, if partly reverting the commit (86434744) could solve the problem.

I'm so sorry I missed the last emails for this discussion.

Yes, commit (86434744) is the trigger of the problem described in
https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t .

And I have tested just remove the following lines from smc_connection() can solve the above problem.
if (smc->use_fallback)
goto out;

I aggree that partly reverting the commit (86434744) is a better solution.

Thanks,
Guangguan Wang