From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE6717823B for ; Mon, 25 Mar 2024 03:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711336960; cv=none; b=ZDFRGI1Au+sRNao0DrQQTVe6KdUNSzGWrQQGQLCgqTa7TqoG5bMwzcV9f9q8CHLLDzENV6U6VZbXOhLRZrNNF2ODzJnSIqqbaAd1nvKm0JzpW9o2KNRYNLHquQubu2/ZEgNbCyWDIZ6iGcFecbJL9vh2nJ6oYYW9hzJlev5FD90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711336960; c=relaxed/simple; bh=orRwZ9kcZJC8yMO1NEBXxCXq9LAMQc3UsRDQLy0IaM0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dEY0bSD57gmxvby6510Y9w8wh5L/lMEsb6gR70S0dISohHW8JR2C8/ihksPwN6U9YTDEnOW4q6/bgn1BJ/j/b8ygwd6sCnai9jewAh7OO6fqhiAwOdS1fLnzifX66fvUf0EzbfPV7Wqb9imV1De/IkRTHcfs4kZsW4TUOaIWFQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=dcdZTaXJ; arc=none smtp.client-ip=44.202.169.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="dcdZTaXJ" Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id oR14rCUiUs4yToauurgWee; Mon, 25 Mar 2024 03:22:32 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id oautrttcviDneoautrmjZ3; Mon, 25 Mar 2024 03:22:31 +0000 X-Authority-Analysis: v=2.4 cv=Cd4O5qrl c=1 sm=1 tr=0 ts=6600edf7 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=UtBFqMlDG83dypD0sxEoAQ==:17 a=IkcTkHD0fZMA:10 a=K6JAEmCyrfEA:10 a=wYkD_t78qR0A:10 a=eNdQz-wj4_MDoatRon4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YOuO9JEjJXNfSgBKj1LiPw0cso3zHCBPu7p7n4bAXp8=; b=dcdZTaXJ8UBns8wJ+bl2v7r+xW VdKDUnj4KW5zlC97s1jUwbzElWLM5xGk2O9qdQGPasJpGAYd4gUpZugXwP+a8l4IdFch4qEYj86FR tOGFx+0+ANM3Bw14KItjkJwzmWCa9ZpaB6xxEleK83WCRRa4UAhisI8BxS2VWYx7s5ynzxE18tAqd z/IJ68wCybmXGM3ux20DolVcY+xGD6rA+CagFMU+YilXW6gmyDyHVztPGIspEY0ozdOwXx3q4bj2z 2LLRWHE9PL9hNauhbEmxdBDEYbZtWrHcDy3IIZIzuCCLKggZ8QiuA4dXXMhiDigwfdVzltvgI940N fofVanyw==; Received: from [201.172.174.229] (port=50482 helo=[192.168.15.14]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1roaur-0034lI-0F; Sun, 24 Mar 2024 22:22:29 -0500 Message-ID: <4064c408-3d73-4361-98f0-718f4f5e54a2@embeddedor.com> Date: Sun, 24 Mar 2024 21:22:25 -0600 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2][next] net/smc: Avoid -Wflex-array-member-not-at-end warnings Content-Language: en-US To: Wen Gu , "Gustavo A. R. Silva" , Wenjia Zhang , Jan Karcher , "D. Wythe" , Tony Lu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook References: From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.174.229 X-Source-L: No X-Exim-ID: 1roaur-0034lI-0F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.14]) [201.172.174.229]:50482 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLDEWnqyx/KL3IE1pdYOHaz5Y+p9TL5vrSAprU3zyzKP9sqvOBbW5QtOVSMaTvLzENvtUeSuPDWNdifeb1KxKws7OeTofdjlSHQkBTuhYoWAC98MMVLW Y7cDyibLSWSH307yT2NORHYCGJkvbi2GFm7nJFTDYsRasrHLKx/N4PF6oTRbvlbkPxnvZFzOKiqeJ0y6gunoTWK2cr9yGbCzqjpUWtFBacjONReABTaGnXUA >> diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c >> index e55026c7529c..63bb5745ab54 100644 >> --- a/net/smc/smc_clc.c >> +++ b/net/smc/smc_clc.c >> @@ -853,8 +853,9 @@ int smc_clc_send_proposal(struct smc_sock *smc, struct smc_init_info *ini) >>       pclc_smcd = &pclc->pclc_smcd; >>       pclc_prfx = &pclc->pclc_prfx; >>       ipv6_prfx = pclc->pclc_prfx_ipv6; >> -    v2_ext = &pclc->pclc_v2_ext; >> -    smcd_v2_ext = &pclc->pclc_smcd_v2_ext; >> +    v2_ext = container_of(&pclc->pclc_v2_ext, struct smc_clc_v2_extension, fixed); > checkpatch complained 'WARNING: line length of 86 exceeds 80 columns' here. I could probably change this. > > It can be reproduced by: > > ./scripts/checkpatch.pl --strict --max-line-length=80 > --ignore=COMMIT_LOG_LONG_LINE,MACRO_ARG_REUSE,ALLOC_SIZEOF_STRUCT,NO_AUTHOR_SIGN_OFF,GIT_COMMIT_ID,CAMELCASE xxx.patch > >> +    smcd_v2_ext = container_of(&pclc->pclc_smcd_v2_ext, >> +                   struct smc_clc_smcd_v2_extension, fixed); >>       gidchids = pclc->pclc_gidchids; >>       trl = &pclc->pclc_trl; >> diff --git a/net/smc/smc_clc.h b/net/smc/smc_clc.h >> index 7cc7070b9772..2bfb51daf468 100644 >> --- a/net/smc/smc_clc.h >> +++ b/net/smc/smc_clc.h >> @@ -134,12 +134,14 @@ struct smc_clc_smcd_gid_chid { >>                */ >>   struct smc_clc_v2_extension { >> -    struct smc_clnt_opts_area_hdr hdr; >> -    u8 roce[16];        /* RoCEv2 GID */ >> -    u8 max_conns; >> -    u8 max_links; >> -    __be16 feature_mask; >> -    u8 reserved[12]; >> +    struct_group_tagged(smc_clc_v2_extension_fixed, fixed, >> +        struct smc_clnt_opts_area_hdr hdr; > > checkpatch: 'CHECK: Alignment should match open parenthesis' I think the code looks better as is --without aligning to match the parenthesis. -- Gustavo