From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel References: <1556283688-556-1-git-send-email-pmorel@linux.ibm.com> <1556283688-556-4-git-send-email-pmorel@linux.ibm.com> <20190430160031.198b83c1.pasic@linux.ibm.com> From: Pierre Morel Date: Tue, 30 Apr 2019 16:03:30 +0200 MIME-Version: 1.0 In-Reply-To: <20190430160031.198b83c1.pasic@linux.ibm.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <40c7e3a5-06b1-8ab9-e32d-c0305c60d63f@linux.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Halil Pasic Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com, cohuck@redhat.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, freude@linux.ibm.com, mimu@linux.ibm.com List-ID: On 30/04/2019 16:00, Halil Pasic wrote: > On Fri, 26 Apr 2019 15:01:27 +0200 > Pierre Morel wrote: > >> diff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h >> index 18dcc4d..7cc02ff 100644 >> --- a/drivers/s390/crypto/vfio_ap_private.h >> +++ b/drivers/s390/crypto/vfio_ap_private.h >> @@ -4,6 +4,7 @@ >> * >> * Author(s): Tony Krowiak >> * Halil Pasic >> + * Pierre Morel >> * >> * Copyright IBM Corp. 2018 >> */ >> @@ -90,4 +91,14 @@ struct ap_matrix_mdev { >> extern int vfio_ap_mdev_register(void); >> extern void vfio_ap_mdev_unregister(void); >> >> +struct vfio_ap_queue { >> + struct ap_matrix_mdev *matrix_mdev; >> + unsigned long a_nib; >> + unsigned long a_pfn; >> + unsigned long p_pfn; >> + int apqn; >> +#define VFIO_AP_ISC_INVALID 0xff > > How about -1? > >> + unsigned char a_isc; >> + unsigned char p_isc; >> +}; >> #endif /* _VFIO_AP_PRIVATE_H_ */ > > I assume a_ and p_ are for argument and private, or? Anyway it would be > nice to have nicer names for these. > > If the a_ members are really just arguments, we could probably live > without the. I'm fine either way. > > Regards, > Halil > Since there will be another iteration to modify other part of this patch I will simplify this handling and make the names clearer. Thanks Pierre -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany