From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-s390@vger.kernel.org,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Joe Perches <joe@perches.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 14/17] s390/debug: Improve a size determination in debug_sprintf_format_fn()
Date: Sat, 3 Sep 2016 14:34:09 +0200 [thread overview]
Message-ID: <40fd0234-45c3-6856-43b3-c7528a794e8e@users.sourceforge.net> (raw)
In-Reply-To: <e4359dc9-9e20-e33b-9743-9ebade853268@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Sep 2016 14:32:08 +0200
Replace a multiplication by a reference for a local array variable
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index 32ceb5e..6792a9c 100644
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -1486,7 +1486,7 @@ debug_sprintf_format_fn(debug_info_t * id, struct debug_view *view,
/* number of arguments used for sprintf (without the format string) */
num_used_args = min(DEBUG_SPRINTF_MAX_ARGS, (num_longs - 1));
- memset(index, 0, DEBUG_SPRINTF_MAX_ARGS * sizeof(int));
+ memset(index, 0, sizeof(index));
for (i = 0; i < num_used_args; i++)
index[i] = i;
--
2.9.3
next prev parent reply other threads:[~2016-09-03 12:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566ABCD9.1060404@users.sourceforge.net>
2016-01-03 10:00 ` [PATCH 0/2] 390/qeth: Fine-tuning for qeth_core_set_online() SF Markus Elfring
2016-01-03 10:02 ` [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() SF Markus Elfring
2016-01-04 11:29 ` Heiko Carstens
2016-01-07 14:33 ` Ursula Braun
2016-01-08 7:18 ` SF Markus Elfring
2016-01-08 8:25 ` Ursula Braun
2016-01-08 12:00 ` SF Markus Elfring
2016-01-03 10:02 ` [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() SF Markus Elfring
2016-01-04 11:30 ` Heiko Carstens
2016-01-04 13:10 ` SF Markus Elfring
2016-01-04 14:04 ` Heiko Carstens
2016-01-04 14:10 ` SF Markus Elfring
2016-01-05 7:54 ` Heiko Carstens
2016-08-20 17:32 ` [PATCH] s390/tape: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2016-08-22 6:24 ` Martin Schwidefsky
2016-09-03 12:04 ` [PATCH 00/17] s390/debug: Fine-tuning for several function implementations SF Markus Elfring
2016-09-03 12:10 ` [PATCH 01/17] s390/debug: Use kmalloc_array() in debug_areas_alloc() SF Markus Elfring
2016-09-03 12:13 ` [PATCH 02/17] s390/debug: Delete unnecessary braces SF Markus Elfring
2016-09-03 12:14 ` [PATCH 03/17] s390/debug: Add some spaces for better code readability SF Markus Elfring
2016-09-03 12:16 ` [PATCH 04/17] s390/debug: Rename jump labels in debug_areas_alloc() SF Markus Elfring
2016-09-03 12:18 ` [PATCH 05/17] s390/debug: Fix jump targets in debug_info_alloc() SF Markus Elfring
2016-09-03 12:20 ` [PATCH 06/17] s390/debug: Rename jump labels in debug_info_copy() SF Markus Elfring
2016-09-03 12:21 ` [PATCH 07/17] s390/debug: Rename jump labels in debug_open() SF Markus Elfring
2016-09-03 12:23 ` [PATCH 08/17] s390/debug: Fix a jump target in debug_register_mode() SF Markus Elfring
2016-09-03 12:24 ` [PATCH 09/17] s390/debug: Return directly if a null pointer was passed to debug_unregister() SF Markus Elfring
2016-09-03 12:42 ` walter harms
2016-09-03 12:26 ` [PATCH 10/17] s390/debug: Delete an unnecessary initialisation in debug_prolog_level_fn() SF Markus Elfring
2016-09-03 12:28 ` [PATCH 11/17] s390/debug: Fix indentation in 13 functions SF Markus Elfring
2016-09-03 12:30 ` [PATCH 12/17] s390/debug: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2016-09-03 13:10 ` kbuild test robot
2016-09-03 12:32 ` [PATCH 13/17] s390/debug: Improve a size determination in debug_open() SF Markus Elfring
2016-09-03 12:34 ` SF Markus Elfring [this message]
2016-09-03 12:36 ` [PATCH 15/17] s390/debug: Improve a size determination in debug_raw_header_fn() SF Markus Elfring
2016-09-03 12:38 ` [PATCH 16/17] s390/debug: Improve determination of sizes in debug_info_alloc() SF Markus Elfring
2016-09-03 12:40 ` [PATCH 17/17] s390/debug: Improve another size determination " SF Markus Elfring
2016-09-05 10:31 ` [PATCH 00/17] s390/debug: Fine-tuning for several function implementations Martin Schwidefsky
2016-09-05 10:40 ` SF Markus Elfring
2016-09-09 16:50 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40fd0234-45c3-6856-43b3-c7528a794e8e@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dahi@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).