Re: [kvm-unit-tests PATCH 5/5] lib: s390x: Handle debug prints for SIE exceptions correctly

Claudio Imbrenda
2022-11-30T14:46:16Z

On Wed, 30 Nov 2022 15:38:53 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 11/23/22 14:01, Claudio Imbrenda wrote:
> > On Wed, 23 Nov 2022 08:46:56 +0000
> > Janosch Frank <frankja@linux.ibm.com> wrote:
> >
> >> When we leave SIE due to an exception, we'll still have guest values
> >> in registers 0 - 13 and that's not clearly portraied in our debug
> >> prints. So let's fix that.
> >
> > wouldn't it be cleaner to restore the registers in the interrupt
> > handler? (I thought we were already doing it)
>
> You mean RESTORE_REGS_STACK? Please don't make me write this in assembly...
>
> RESTORE_REGS_STACK is doing test/pgm register swapping, it doesn't care
> if the test registers are "host" or "guest" registers.

fair enough :)