From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <471F15D5.3050100@linux.vnet.ibm.com> Date: Wed, 24 Oct 2007 15:22:21 +0530 From: Balbir Singh MIME-Version: 1.0 Subject: Re: [PATCH] taskstats scaled time cleanup References: <8789.1193208897@neuling.org> In-Reply-To: <8789.1193208897@neuling.org> Content-Type: text/plain; charset=ISO-8859-1 Reply-To: balbir@linux.vnet.ibm.com List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Archive: List-Post: To: Michael Neuling Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, linux390@de.ibm.com, akpm@linux-foundation.org List-ID: Michael Neuling wrote: > This moves the ability to scale cputime into generic code. This > allows us to fix the issue in kernel/timer.c (noticed by Balbir) where > we could only add an unscaled value to the scaled utime/stime. > > This adds a cputime_to_scaled function. As before, the POWERPC > version does the scaling based on the last SPURR/PURR ratio > calculated. The generic and s390 (only other arch to implement > asm/cputime.h) versions are both NOPs. > > Also moves the SPURR and PURR snapshots closer. > > Signed-off-by: Michael Neuling Looks good to me Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL