From: Harald Freudenberger <freude@linux.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dengler@linux.ibm.com, ifranzki@linux.ibm.com,
linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
fcallies@linux.ibm.com
Subject: Re: [PATCH v11 5/6] s390/crypto: Add selftest support for phmac
Date: Mon, 26 May 2025 15:58:46 +0200 [thread overview]
Message-ID: <48c8cfa0a00d34f271d04d9d68dc7337@linux.ibm.com> (raw)
In-Reply-To: <aC7qCsLN84LfWy-e@gondor.apana.org.au>
On 2025-05-22 11:10, Herbert Xu wrote:
> On Thu, May 22, 2025 at 10:57:54AM +0200, Harald Freudenberger wrote:
>>
>> + if (!(crypto_tfm_alg_get_flags(tfm_base) & CRYPTO_ALG_TESTED)) {
>
> I think a better helper would be
>
> if (!crypto_ahash_tested(tfm)) {
>
> Thanks,
Done, there is now a new inline function:
static inline bool crypto_ahash_tested(struct crypto_ahash *tfm)
{
struct crypto_tfm *tfm_base = crypto_ahash_tfm(tfm);
return tfm_base->__crt_alg->cra_flags & CRYPTO_ALG_TESTED;
}
in include/crypto/internal/hash.h
see v12 of this patch series.
next prev parent reply other threads:[~2025-05-26 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 8:57 [PATCH v11 0/6] New s390 specific protected key hmac Harald Freudenberger
2025-05-22 8:57 ` [PATCH v11 1/6] crypto: ahash - make hash walk functions from ahash.c public Harald Freudenberger
2025-05-23 14:58 ` Holger Dengler
2025-05-22 8:57 ` [PATCH v11 2/6] s390/crypto: Add protected key hmac subfunctions for KMAC Harald Freudenberger
2025-05-23 15:00 ` Holger Dengler
2025-05-22 8:57 ` [PATCH v11 3/6] s390/crypto: New s390 specific protected key hash phmac Harald Freudenberger
2025-05-23 14:52 ` Holger Dengler
2025-05-26 14:02 ` Harald Freudenberger
2025-05-22 8:57 ` [PATCH v11 4/6] crypto: api - Add crypto_tfm_alg_get_flags() helper inline function Harald Freudenberger
2025-05-23 15:02 ` Holger Dengler
2025-05-22 8:57 ` [PATCH v11 5/6] s390/crypto: Add selftest support for phmac Harald Freudenberger
2025-05-22 9:10 ` Herbert Xu
2025-05-26 13:58 ` Harald Freudenberger [this message]
2025-05-23 14:55 ` Holger Dengler
2025-05-26 14:06 ` Harald Freudenberger
2025-05-22 8:57 ` [PATCH v11 6/6] crypto: testmgr - Enable phmac selftest Harald Freudenberger
2025-05-23 15:03 ` Holger Dengler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c8cfa0a00d34f271d04d9d68dc7337@linux.ibm.com \
--to=freude@linux.ibm.com \
--cc=dengler@linux.ibm.com \
--cc=fcallies@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=ifranzki@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).