From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C3691369A7 for ; Thu, 21 Mar 2024 22:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711060193; cv=none; b=knOGNgGD1g0Nc9tHw2HMsNgovMNlkWm0NWpoXPgKwY8WLW9EqF6crf6q1Wj3qjpytcligIM+tPHxbTZ55FVTf/TwV0pWs6JpCuGalVz8mWEjOCIz7wfexKmSwHNDauRDlQZxdAfhfpQzGezfV2TMnweuRdHQXDrHSCgHiAtIu3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711060193; c=relaxed/simple; bh=dMjHyU5GItR9uCuiDMA0qfZIY8n0qTGA0Ob36mJDMtc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pGgU1wwQAFyg0PEB73Hm128s4PfUfb6VvHQKC4WAeVqqaECDxnFzV1d4bFVWWKaLbPwqxHpWAJpdKEEe4SHks2sE56V3rUdU1Rmrdiyz8BoLqgBTzmbJyH2gS6arQc4VPDNVVCEByG/vf0jr0ADpyDZJnBxIQDfgPENQ2zOerfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g6cHIZqz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g6cHIZqz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711060190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5MggRPNo3+tANcd2X7t6Sxe3iKsgn51LgGVLSTK7Imc=; b=g6cHIZqzBRFcYwTkpxVB6OMsRzmr3fL1uLsF/5P/DQudm5SlUcvuxQ5vvADgMzdfCmTBB8 ZNLdt4xiT9+S5hLCmVm3ofp7arb+YdZh91OmDJMCBSNxJ/zSpqnpULjlDM4Eez4qkaCmwZ c9Zf1Q4Cqo3qaOVRrCwZhq1ulF7rkxM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-DS6XrEHHORy0vFKQsMsmmA-1; Thu, 21 Mar 2024 18:29:48 -0400 X-MC-Unique: DS6XrEHHORy0vFKQsMsmmA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41463be093aso7232635e9.3 for ; Thu, 21 Mar 2024 15:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711060187; x=1711664987; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5MggRPNo3+tANcd2X7t6Sxe3iKsgn51LgGVLSTK7Imc=; b=U1O+Zkv67PTam7Jt2/rz03WPpe7Vl4GcBdywp0cGKQi4OgL1DfVD5AB9Q9YVgdEfhe 0DAGdCoQSQATdn9r216hyIWprGywNe9QFmwESwTX9ULgRF8nCIRc5MqhpSBpdgRMDOEI QoKoqnR77zxboHXyLTXKkwvcJoqwrgJMYzhUYV0rVPLJTA48X5fraI63r2CQIiyUYqoi VTXhwiyN1rgz+FboMAuSo5wI8iRUtI4Nyz9Ged+vnlLGdfzl+OcLv9VScMlMoV4+04a1 AZ70L3F5oXnWVhiTuUtQ/jV0lA4zp/xGd5R2jrBfzq/Y/9yy39HNWNG99TUt88SYBV6P JHdQ== X-Forwarded-Encrypted: i=1; AJvYcCWAangyEcNNg7rquiUdWuQ2Ta6hYNRvXb0Xr+/pdy9D1H6wa+MiNBdkK/4cbPSQ/bViHXUAYMVLSEC7n4wm09LkCm1rGFPTNXqwLQ== X-Gm-Message-State: AOJu0YzdvE7oao2MZzzq40oTJr9CiY7UyzzWzmeyWzgyb4SgY5dKcXFA otZQvD9BTQcQK/n+Ks8Xf3678mAPONidVAgspPp0YLV0QT4SeDMOvIr0KS9IecFFvYsEmaEP85k sA+XTsnkpaiHvq4L1uXHrzmsPDr9Fu0k3vuF1LPAJlNYKWu+qqS19MR7e3aM= X-Received: by 2002:a7b:cb87:0:b0:414:a69:f0b1 with SMTP id m7-20020a7bcb87000000b004140a69f0b1mr329199wmi.13.1711060187480; Thu, 21 Mar 2024 15:29:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhrF06aCr7NvXGkh98cYBZAUc8BMNVKC1tnaNwxBg9kd3uxfKKVoL03MT8TSmNJ2bRAs1ruA== X-Received: by 2002:a7b:cb87:0:b0:414:a69:f0b1 with SMTP id m7-20020a7bcb87000000b004140a69f0b1mr329179wmi.13.1711060186991; Thu, 21 Mar 2024 15:29:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:6100:c68b:6e10:d7be:4e87? (p200300cbc7116100c68b6e10d7be4e87.dip0.t-ipconnect.de. [2003:cb:c711:6100:c68b:6e10:d7be:4e87]) by smtp.gmail.com with ESMTPSA id b2-20020a05600c4e0200b0041312c4865asm6981889wmq.2.2024.03.21.15.29.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 15:29:46 -0700 (PDT) Message-ID: <48d1282c-e4db-4b55-ab3f-3344af2440c4@redhat.com> Date: Thu, 21 Mar 2024 23:29:45 +0100 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Alexander Gordeev , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240321215954.177730-1-david@redhat.com> <20240321215954.177730-2-david@redhat.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.03.24 23:20, Peter Xu wrote: > On Thu, Mar 21, 2024 at 10:59:53PM +0100, David Hildenbrand wrote: >> s390x must disable shared zeropages for processes running VMs, because >> the VMs could end up making use of "storage keys" or protected >> virtualization, which are incompatible with shared zeropages. >> >> Yet, with userfaultfd it is possible to insert shared zeropages into >> such processes. Let's fallback to simply allocating a fresh zeroed >> anonymous folio and insert that instead. >> >> mm_forbids_zeropage() was introduced in commit 593befa6ab74 ("mm: introduce >> mm_forbids_zeropage function"), briefly before userfaultfd went >> upstream. >> >> Note that we don't want to fail the UFFDIO_ZEROPAGE request like we do >> for hugetlb, it would be rather unexpected. Further, we also >> cannot really indicated "not supported" to user space ahead of time: it >> could be that the MM disallows zeropages after userfaultfd was already >> registered. >> >> Fixes: c1a4de99fada ("userfaultfd: mcopy_atomic|mfill_zeropage: UFFDIO_COPY|UFFDIO_ZEROPAGE preparation") >> Signed-off-by: David Hildenbrand > > Reviewed-by: Peter Xu > > Still, a few comments below. > >> --- >> mm/userfaultfd.c | 35 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c >> index 712160cd41eca..1d1061ccd1dea 100644 >> --- a/mm/userfaultfd.c >> +++ b/mm/userfaultfd.c >> @@ -316,6 +316,38 @@ static int mfill_atomic_pte_copy(pmd_t *dst_pmd, >> goto out; >> } >> >> +static int mfill_atomic_pte_zeroed_folio(pmd_t *dst_pmd, >> + struct vm_area_struct *dst_vma, unsigned long dst_addr) >> +{ >> + struct folio *folio; >> + int ret; > > nitpick: we can set -ENOMEM here, then > >> + >> + folio = vma_alloc_zeroed_movable_folio(dst_vma, dst_addr); >> + if (!folio) >> + return -ENOMEM; > > return ret; > >> + >> + ret = -ENOMEM; > > drop. Sure! > >> + if (mem_cgroup_charge(folio, dst_vma->vm_mm, GFP_KERNEL)) >> + goto out_put; >> + >> + /* >> + * The memory barrier inside __folio_mark_uptodate makes sure that >> + * preceding stores to the page contents become visible before >> + * the set_pte_at() write. >> + */ > > This comment doesn't apply. We can drop it. > I thought the same until I spotted that comment (where uffd originally copied this from I strongly assume) in do_anonymous_page(). "Preceding stores" here are: zeroing out the memory. Thanks for the fast review! -- Cheers, David / dhildenb