* [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization [not found] <20100709150117.51612026.sfr@canb.auug.org.au> @ 2010-07-09 9:45 ` Sachin Sant 2010-07-09 10:08 ` Eric W. Biederman 0 siblings, 1 reply; 8+ messages in thread From: Sachin Sant @ 2010-07-09 9:45 UTC (permalink / raw) To: linux-s390; +Cc: linux-next, LKML, Heiko Carstens, Eric W. Biederman With today's next(20100709) qeth interface fails to initialize with following Badness message: sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 ------------ cut here ------------ Badness at fs/sysfs/symlink.c:82 Modules linked in: qeth_l3 ipv6 qeth qdio vmur ccwgroup scsi_dh_alua scsi_dh_rda c scsi_dh_hp_sw scsi_dh_emc dm_zero ext3 mbcache multipath jbd dm_snapshot dm_mi rror dm_region_hash dm_log dm_round_robin dm_multipath dm_mod scsi_dh sd_mod scs i_mod crc_t10dif dasd_fba_mod dasd_eckd_mod dasd_mod CPU: 0 Tainted: G W 2.6.35-rc4-autotest-next-20100709-5-default #1 Process udevd (pid: 587, task: 00000000fcdc0038, ksp: 00000000faa4f9a8) Krnl PSW : 0704000180000000 00000000002ac5b0 (sysfs_do_create_link+0x120/0x268) R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:0 PM:0 EA:3 Krnl GPRS: 0000000000010000 0000000000719408 0000000000000043 00000000ffffffff 000000000045bf5a 0000000000000000 00000000fa96b640 0000000000000001 0000000000000001 00000000faa4fbb0 00000000fca76500 00000000fb139a50 0000000000000000 000000000048be60 00000000002ac5ac 00000000faa4fb10 Krnl Code: 00000000002ac5a0: c020001545ad larl %r2,5550fa 00000000002ac5a6: c0e5000d7cb1 brasl %r14,45bf08 00000000002ac5ac: a7f40001 brc 15,2ac5ae >00000000002ac5b0: b9040029 lgr %r2,%r9 00000000002ac5b4: a7c8ffea lhi %r12,-22 00000000002ac5b8: c0e5fffffbf8 brasl %r14,2abda8 00000000002ac5c2: 5830b000 l %r3,0(%r11) Call Trace: (<00000000002ac5ac> sysfs_do_create_link+0x11c/0x268) <0000000000358f62> device_add+0x6c2/0x734 <00000000003cffa8> netdev_register_kobject+0x88/0x188 <00000000003be7aa> register_netdevice+0x236/0x450 <00000000003bea1e> register_netdev+0x5a/0x74 <000003c00633a5b8> __qeth_l3_set_online+0x9d8/0x1518 qeth_l3 <000003c004cb4ada> ccwgroup_online_store+0x1e6/0x230 ccwgroup <00000000002a9e10> sysfs_write_file+0xec/0x19c <00000000002301d0> vfs_write+0xac/0x184 <000000000023039e> SyS_write+0x52/0xa8 <00000000001195ee> sysc_noemu+0x10/0x16 <0000020000151444> 0x20000151444 Last Breaking-Event-Address: <00000000002ac5ac> sysfs_do_create_link+0x11c/0x268 Yesterday's next was good. Last commit that changed symlink.c was commit d7866652cda316006089fa42b931627992c08010 sysfs: Don't allow the creation of symlinks we can't remove This commit added the above WARN() message. I haven't tried to revert this commit to check if that helps with qeth initialization. Thanks -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India --------------------------------- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 9:45 ` [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization Sachin Sant @ 2010-07-09 10:08 ` Eric W. Biederman 2010-07-09 10:27 ` Sachin Sant 0 siblings, 1 reply; 8+ messages in thread From: Eric W. Biederman @ 2010-07-09 10:08 UTC (permalink / raw) To: Sachin Sant; +Cc: linux-s390, linux-next, LKML, Heiko Carstens Sachin Sant <sachinp@in.ibm.com> writes: > With today's next(20100709) qeth interface fails to initialize > with following Badness message: > sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 Is this with CONFIG_SYSFS_DEPRECATED set? I think I may have made my warning check a little extra strict. Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 10:08 ` Eric W. Biederman @ 2010-07-09 10:27 ` Sachin Sant 2010-07-09 10:39 ` Eric W. Biederman 2010-07-09 14:28 ` Greg KH 0 siblings, 2 replies; 8+ messages in thread From: Sachin Sant @ 2010-07-09 10:27 UTC (permalink / raw) To: Eric W. Biederman; +Cc: linux-s390, linux-next, LKML, Heiko Carstens Eric W. Biederman wrote: >> With today's next(20100709) qeth interface fails to initialize >> with following Badness message: >> >> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 >> > > Is this with CONFIG_SYSFS_DEPRECATED set? > > I think I may have made my warning check a little extra strict. > Yes. CONFIG_SYSFS_DEPRECATED=y CONFIG_SYSFS_DEPRECATED_V2=y Thanks -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India --------------------------------- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 10:27 ` Sachin Sant @ 2010-07-09 10:39 ` Eric W. Biederman 2010-07-09 14:28 ` Greg KH 1 sibling, 0 replies; 8+ messages in thread From: Eric W. Biederman @ 2010-07-09 10:39 UTC (permalink / raw) To: Sachin Sant; +Cc: linux-s390, linux-next, LKML, Heiko Carstens Sachin Sant <sachinp@in.ibm.com> writes: > Eric W. Biederman wrote: >>> With today's next(20100709) qeth interface fails to initialize >>> with following Badness message: >>> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 >>> >> >> Is this with CONFIG_SYSFS_DEPRECATED set? >> >> I think I may have made my warning check a little extra strict. >> > Yes. > > CONFIG_SYSFS_DEPRECATED=y > CONFIG_SYSFS_DEPRECATED_V2=y Ugh. It looks like the warning is correct and I have a regression in 2.6.35 that was overlooked because I did not closely test CONIFG_SYSFS_DEPRECATED. I will see if I can cook up a proper patch shortly. Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 10:27 ` Sachin Sant 2010-07-09 10:39 ` Eric W. Biederman @ 2010-07-09 14:28 ` Greg KH 2010-07-09 15:33 ` Martin Schwidefsky 2010-07-09 15:56 ` Sachin Sant 1 sibling, 2 replies; 8+ messages in thread From: Greg KH @ 2010-07-09 14:28 UTC (permalink / raw) To: Sachin Sant Cc: Eric W. Biederman, linux-s390, linux-next, LKML, Heiko Carstens On Fri, Jul 09, 2010 at 03:57:00PM +0530, Sachin Sant wrote: > Eric W. Biederman wrote: >>> With today's next(20100709) qeth interface fails to initialize >>> with following Badness message: >>> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 >>> >> >> Is this with CONFIG_SYSFS_DEPRECATED set? >> >> I think I may have made my warning check a little extra strict. >> > Yes. > > CONFIG_SYSFS_DEPRECATED=y > CONFIG_SYSFS_DEPRECATED_V2=y Why do you have those options enabled? Does your userspace really require them? I want to remove those options soon, and it would be good to find out what is still relying on them. If you disable those options, does it then work? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 14:28 ` Greg KH @ 2010-07-09 15:33 ` Martin Schwidefsky 2010-07-09 15:59 ` Greg KH 2010-07-09 15:56 ` Sachin Sant 1 sibling, 1 reply; 8+ messages in thread From: Martin Schwidefsky @ 2010-07-09 15:33 UTC (permalink / raw) To: Greg KH Cc: Sachin Sant, Eric W. Biederman, linux-s390, linux-next, LKML, Heiko Carstens On Fri, 9 Jul 2010 07:28:18 -0700 Greg KH <greg@kroah.com> wrote: > On Fri, Jul 09, 2010 at 03:57:00PM +0530, Sachin Sant wrote: > > Eric W. Biederman wrote: > >>> With today's next(20100709) qeth interface fails to initialize > >>> with following Badness message: > >>> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 > >>> > >> > >> Is this with CONFIG_SYSFS_DEPRECATED set? > >> > >> I think I may have made my warning check a little extra strict. > >> > > Yes. > > > > CONFIG_SYSFS_DEPRECATED=y > > CONFIG_SYSFS_DEPRECATED_V2=y > > Why do you have those options enabled? Does your userspace really > require them? I want to remove those options soon, and it would be good > to find out what is still relying on them. > > If you disable those options, does it then work? The default configuration for s390 does not have the options enabled and with a recent userspace everything works just fine. From my point of view the two options can be removed. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 15:33 ` Martin Schwidefsky @ 2010-07-09 15:59 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2010-07-09 15:59 UTC (permalink / raw) To: Martin Schwidefsky Cc: Sachin Sant, Eric W. Biederman, linux-s390, linux-next, LKML, Heiko Carstens On Fri, Jul 09, 2010 at 05:33:26PM +0200, Martin Schwidefsky wrote: > On Fri, 9 Jul 2010 07:28:18 -0700 > Greg KH <greg@kroah.com> wrote: > > > On Fri, Jul 09, 2010 at 03:57:00PM +0530, Sachin Sant wrote: > > > Eric W. Biederman wrote: > > >>> With today's next(20100709) qeth interface fails to initialize > > >>> with following Badness message: > > >>> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 > > >>> > > >> > > >> Is this with CONFIG_SYSFS_DEPRECATED set? > > >> > > >> I think I may have made my warning check a little extra strict. > > >> > > > Yes. > > > > > > CONFIG_SYSFS_DEPRECATED=y > > > CONFIG_SYSFS_DEPRECATED_V2=y > > > > Why do you have those options enabled? Does your userspace really > > require them? I want to remove those options soon, and it would be good > > to find out what is still relying on them. > > > > If you disable those options, does it then work? > > The default configuration for s390 does not have the options enabled and > with a recent userspace everything works just fine. From my point of view > the two options can be removed. Wonderful, thanks for letting me know. Sachin, care to disable them in your image as well? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization 2010-07-09 14:28 ` Greg KH 2010-07-09 15:33 ` Martin Schwidefsky @ 2010-07-09 15:56 ` Sachin Sant 1 sibling, 0 replies; 8+ messages in thread From: Sachin Sant @ 2010-07-09 15:56 UTC (permalink / raw) To: Greg KH; +Cc: Eric W. Biederman, linux-s390, linux-next, LKML, Heiko Carstens Greg KH wrote: > On Fri, Jul 09, 2010 at 03:57:00PM +0530, Sachin Sant wrote: > >> Eric W. Biederman wrote: >> >>>> With today's next(20100709) qeth interface fails to initialize >>>> with following Badness message: >>>> sysfs: symlink across ns_types 0.0.6000/net:eth0 -> net/eth0 >>>> >>>> >>> Is this with CONFIG_SYSFS_DEPRECATED set? >>> >>> I think I may have made my warning check a little extra strict. >>> >>> >> Yes. >> >> CONFIG_SYSFS_DEPRECATED=y >> CONFIG_SYSFS_DEPRECATED_V2=y >> > > Why do you have those options enabled? Does your userspace really > require them? I want to remove those options soon, and it would be good > to find out what is still relying on them. > > If you disable those options, does it then work? > Not sure when and why i enabled these options. Without them i don't see any problem (including the badness). Thanks -Sachin > thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-s390" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India --------------------------------- ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-07-09 15:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100709150117.51612026.sfr@canb.auug.org.au>
2010-07-09 9:45 ` [-next July 9 - s390 ] Badness at fs/sysfs/symlink.c:82 during qeth initalization Sachin Sant
2010-07-09 10:08 ` Eric W. Biederman
2010-07-09 10:27 ` Sachin Sant
2010-07-09 10:39 ` Eric W. Biederman
2010-07-09 14:28 ` Greg KH
2010-07-09 15:33 ` Martin Schwidefsky
2010-07-09 15:59 ` Greg KH
2010-07-09 15:56 ` Sachin Sant
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).