From: Chris Metcalf <cmetcalf@tilera.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Helge Deller <deller@gmx.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 9/9] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS
Date: Thu, 12 May 2011 20:55:25 -0400 [thread overview]
Message-ID: <4DCC817D.3090005@tilera.com> (raw)
In-Reply-To: <1305244212-19183-10-git-send-email-sboyd@codeaurora.org>
On 5/12/2011 7:50 PM, Stephen Boyd wrote:
> The help text for this config is duplicated across the x86,
> parisc, and s390 Kconfig.debug files. Arnd Bergman noted that the
> help text was slightly misleading and should be fixed to state
> that enabling this option isn't a problem when using pre 4.4 gcc.
>
> To simplify the rewording, consolidate the text into
> lib/Kconfig.debug and modify it there to be more explicit about
> when you should say N to this config.
>
> Also, make the text a bit more generic by stating that this
> option enables compile time checks so we can cover architectures
> which emit warnings vs. ones which emit errors. The details of
> how an architecture decided to implement the checks isn't as
> important as the concept of compile time checking of
> copy_from_user() calls.
>
> While we're doing this, remove all the copy_from_user_overflow()
> code that's duplicated many times and place it into lib/ so that
> any architecture supporting this option can get the function for
> free.
>
> ---
> arch/tile/Kconfig | 8 +-------
> arch/tile/include/asm/uaccess.h | 7 ++++++-
> arch/tile/lib/uaccess.c | 8 --------
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2011-05-13 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1305244212-19183-1-git-send-email-sboyd@codeaurora.org>
2011-05-12 23:50 ` [PATCH 9/9] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2011-05-13 0:55 ` Chris Metcalf [this message]
2011-05-13 7:31 ` Ingo Molnar
2011-05-13 16:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC817D.3090005@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox