Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous sentinel elements from ctl_table array

Joel Granados
2024-05-07T08:02:29Z

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

On Fri, May 03, 2024 at 06:23:14PM +0300, Dan Carpenter wrote:
> On Fri, May 03, 2024 at 02:18:11PM +0200, Joel Granados wrote:
> > On Wed, May 01, 2024 at 03:15:54PM +0200, Sabrina Dubroca wrote:
> > > 2024-05-01, 11:29:32 +0200, Joel Granados via B4 Relay wrote:
> > > > From: Joel Granados <j.granados@samsung.com>
> > > > diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
> > > > index c4f8adbf8144..c50a58d9e368 100644
> > > > --- a/net/ax25/ax25_ds_timer.c
> > > > +++ b/net/ax25/ax25_ds_timer.c
> > > > @@ -55,6 +55,7 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev)
> > > > ax25_dev->dama.slave_timeout =
> > > > msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
> > > > mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
> > > > + return;
> > >
> > > nit: return not needed here since we're already at the bottom of the
> > > function, but probably not worth a repost of the series.
> > >
> > Thx. I will not repost, but I have changed them locally so they are
> > there in case a V7 is required.
> >
>
> It's a checkpatch.pl -f warning so we probably will want to fix it
> eventually.

According to [1] the patchset has already been applied. So I'll just
send another patch for it to be applied on top.

Thx for pointing this out.

[1] https://patchwork.kernel.org/project/netdevbpf/patch/20240501-jag-sysctl_remset_net-v6-1-370b702b6b4a@samsung.com/
--

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]