Re: [PATCH net-next v6 0/8] sysctl: Remove sentinel elements from networking

Joel Granados
2024-05-03T12:20:53Z

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Wed, May 01, 2024 at 03:22:08PM +0200, Sabrina Dubroca wrote:
> 2024-05-01, 11:29:24 +0200, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@samsung.com>
> >
...
> > Changes in v6:
> > - Rebased onto net-next/main.
> > - Besides re-running my cocci scripts, I ran a new find script [9].
> > Found 0 hits in net/
> > - Moved "i" variable declaraction out of for() in sysctl_core_net_init
> > - Removed forgotten sentinel in mpls_table
> > - Removed CONFIG_AX25_DAMA_SLAVE guard from net/ax25/ax25_ds_timer.c. It
> > is not needed because that file is compiled only when
> > CONFIG_AX25_DAMA_SLAVE is set.
> > - When traversing smc_table, stop on ARRAY_SIZE instead of ARRAY_SIZE-1.
> > - Link to v5: https://lore.kernel.org/r/20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com
>
> I pointed out a few tiny details in the ax25 patch but either way, the
> series looks good to me. Thanks!
>
> Series:
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thx

>
> Note that you could have kept the ack/reviewed-by on patch 4 since it
> was not modified. Jeff and Chuck, your reviews got lost in the repost.
Indeed. I have been having issues with my b4. Have posted this
https://lore.kernel.org/tools/20240503120506.p7g5nn6jocrrdlck@joelS2.panther.com/
which explains my situation.

Best

--

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]