Re: [PATCH net-next v6 3/8] net: rds: Remove the now superfluous sentinel elements from ctl_table array

Allison Henderson
2024-05-03T02:27:34Z

On Wed, 2024-05-01 at 11:29 +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@samsung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/
> )
>
> * Remove sentinel element from ctl_table structs.
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
These changes look fine to me. Thank you!
Acked-by: Allison Henderson <allison.henderson@oracle.com>

> ---
>  net/rds/ib_sysctl.c | 1 -
>  net/rds/sysctl.c    | 1 -
>  net/rds/tcp.c       | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c
> index e4e41b3afce7..2af678e71e3c 100644
> --- a/net/rds/ib_sysctl.c
> +++ b/net/rds/ib_sysctl.c
> @@ -103,7 +103,6 @@ static struct ctl_table rds_ib_sysctl_table[] = {
>                 .mode           = 0644,
>                 .proc_handler   = proc_dointvec,
>         },
> -       { }
>  };
>
>  void rds_ib_sysctl_exit(void)
> diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c
> index e381bbcd9cc1..025f518a4349 100644
> --- a/net/rds/sysctl.c
> +++ b/net/rds/sysctl.c
> @@ -89,7 +89,6 @@ static struct ctl_table rds_sysctl_rds_table[] = {
>                 .mode           = 0644,
>                 .proc_handler   = proc_dointvec,
>         },
> -       { }
>  };
>
>  void rds_sysctl_exit(void)
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index 2dba7505b414..d8111ac83bb6 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -86,7 +86,6 @@ static struct ctl_table rds_tcp_sysctl_table[] = {
>                 .proc_handler   = rds_tcp_skbuf_handler,
>                 .extra1         = &rds_tcp_min_rcvbuf,
>         },
> -       { }
>  };
>
>  u32 rds_tcp_write_seq(struct rds_tcp_connection *tc)
>