Re: [PATCH 0/3] KVM: s390: Trace events support.

[Avi Kivity <avi@redhat.com>]

On 07/23/2012 06:20 PM, Cornelia Huck wrote:
> Avi, Marcelo,
> 
> here's a patch set that introduces trace events for kvm/s390.
> 
> It's split into two parts:
> 
> - Trace points for architecture-defined events, like intercepts.
>   This patch calls into the disassembler via the interface provided
>   by the first patch. These trace points show up under events/kvm/.
> - Trace points for implementation-specific events like interrupt
>   injection. These show up under a new trace system, kvm-s390.

I don't see what's the difference between the two types.  Isn't
interrupt injection architectural?

On x86, the implementation tracepoints are ones that may go away if the
implementation changes significantly, while the architectural ones will
not go away unless the architecture is changed.  In fact creation and
destruction of vcpus and reset requests are not only architectural,
they're generic, you may as well add them to the arch independent trace
code.

btw - why are vcpu creation and destruction useful events to trace?

-- 
error compiling committee.c: too many arguments to function