From: Chen Gang <gang.chen@asianux.com>
To: paul.mckenney@linaro.org, josh@joshtriplett.org,
Ben Hutchings <bhutchings@solarflare.com>,
decot@googlers.com
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] include/linux/interrupt.h: add dummy irq_set_irq_wake() for "!GENERIC_HARDIRQS"
Date: Fri, 28 Jun 2013 09:23:08 +0800 [thread overview]
Message-ID: <51CCE57C.5000901@asianux.com> (raw)
In-Reply-To: <51CC046F.2050009@asianux.com>
Since irq_set_irq_wake() has already declared in header file, when
GENERIC_HARDIRQS enabled.
Recommend to define the dummy one for GENERIC_HARDIRQS disabled, and
also let the other related "static inline" functions are independent
from GENERIC_HARDIRQS.
So can avoid the compiling error below, and also let the code simpler
and clearer.
The related compiling error (ARCH=s390 allmodconfig):
sound/soc/codecs/wm0010.c: In function ‘wm0010_spi_probe’:
sound/soc/codecs/wm0010.c:976:2: error: implicit declaration of function ‘irq_set_irq_wake’ [-Werror=implicit-function-declaration]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/linux/interrupt.h | 23 ++++++++++-------------
1 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 5fa5afe..1a311e0 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -344,16 +344,6 @@ static inline void enable_irq_lockdep_irqrestore(unsigned int irq, unsigned long
/* IRQ wakeup (PM) control: */
extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
-static inline int enable_irq_wake(unsigned int irq)
-{
- return irq_set_irq_wake(irq, 1);
-}
-
-static inline int disable_irq_wake(unsigned int irq)
-{
- return irq_set_irq_wake(irq, 0);
-}
-
#else /* !CONFIG_GENERIC_HARDIRQS */
/*
* NOTE: non-genirq architectures, if they want to support the lock
@@ -370,16 +360,23 @@ static inline int disable_irq_wake(unsigned int irq)
enable_irq(irq)
# endif
-static inline int enable_irq_wake(unsigned int irq)
+/* IRQ wakeup (PM) control: */
+static inline int irq_set_irq_wake(unsigned int irq, unsigned int on)
{
return 0;
}
+#endif /* CONFIG_GENERIC_HARDIRQS */
+
+static inline int enable_irq_wake(unsigned int irq)
+{
+ return irq_set_irq_wake(irq, 1);
+}
+
static inline int disable_irq_wake(unsigned int irq)
{
- return 0;
+ return irq_set_irq_wake(irq, 0);
}
-#endif /* CONFIG_GENERIC_HARDIRQS */
#ifdef CONFIG_IRQ_FORCED_THREADING
--
1.7.7.6
prev parent reply other threads:[~2013-06-28 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130625014645.qczOugAFBrMJO-5iGZyzyXFtqrHbXhehGoqqp8JU2eQ@z>
2013-06-25 1:46 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Chen Gang
[not found] ` <20130625015441.yimPsU9P_MbLl68LALkInHU6BHTrHMbIdSo3M3RUxiM@z>
2013-06-25 1:54 ` [Suggestion] arch: s390: mm: the warnings with allmodconfig and "EXTRA_CFLAGS=-W" Chen Gang
[not found] ` <20130625065006.9nVf-cqdfTs0BrmaOdm4f8CQDGItep_9cSWKJDxCLyk@z>
2013-06-25 6:50 ` Martin Schwidefsky
2013-06-25 7:25 ` Chen Gang
2013-06-25 6:48 ` [PATCH] arch: s390: kernel: reset 'c->hotpluggable' when failure occurs Heiko Carstens
2013-06-25 7:24 ` Chen Gang
2013-06-25 9:09 ` Heiko Carstens
2013-06-25 9:31 ` Chen Gang
2013-06-26 1:44 ` Chen Gang
2013-06-27 2:43 ` [PATCH v2] arch: s390: kernel: scan all present cpu forcely Chen Gang
2013-06-27 8:18 ` Heiko Carstens
2013-06-27 9:22 ` Chen Gang
2013-06-28 1:23 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CCE57C.5000901@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=decot@googlers.com \
--cc=heiko.carstens@de.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=paul.mckenney@linaro.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).