* [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
@ 2013-10-22 22:29 Joe Perches
2013-10-22 22:29 ` [PATCH 03/24] s390: " Joe Perches
2013-10-22 23:53 ` [PATCH 00/24] treewide: " David Daney
0 siblings, 2 replies; 5+ messages in thread
From: Joe Perches @ 2013-10-22 22:29 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-kernel, linux-ia64, linux-s390, linux-rdma, linux-raid,
linux-scsi, codalist, linux-fsdevel, linux-cachefs, linux-nfs,
linux-ntfs-dev, ocfs2-devel, keyrings, linux-mm,
linux-security-module
Joe Perches (24):
arm: Convert use of typedef ctl_table to struct ctl_table
ia64: Convert use of typedef ctl_table to struct ctl_table
s390: Convert use of typedef ctl_table to struct ctl_table
tile: Convert use of typedef ctl_table to struct ctl_table
cdrom: Convert use of typedef ctl_table to struct ctl_table
random: Convert use of typedef ctl_table to struct ctl_table
infiniband: Convert use of typedef ctl_table to struct ctl_table
md: Convert use of typedef ctl_table to struct ctl_table
parport: Convert use of typedef ctl_table to struct ctl_table
scsi: Convert use of typedef ctl_table to struct ctl_table
coda: Convert use of typedef ctl_table to struct ctl_table
fscache: Convert use of typedef ctl_table to struct ctl_table
lockd: Convert use of typedef ctl_table to struct ctl_table
nfs: Convert use of typedef ctl_table to struct ctl_table
inotify: Convert use of typedef ctl_table to struct ctl_table
ntfs: Convert use of typedef ctl_table to struct ctl_table
ocfs2: Convert use of typedef ctl_table to struct ctl_table
proc: Convert use of typedef ctl_table to struct ctl_table
fs: Convert use of typedef ctl_table to struct ctl_table
key: Convert use of typedef ctl_table to struct ctl_table
ipc: Convert use of typedef ctl_table to struct ctl_table
kernel: Convert use of typedef ctl_table to struct ctl_table
mm: Convert use of typedef ctl_table to struct ctl_table
security:keys: Convert use of typedef ctl_table to struct ctl_table
arch/arm/kernel/isa.c | 6 ++---
arch/ia64/kernel/crash.c | 4 +--
arch/ia64/kernel/perfmon.c | 6 ++---
arch/s390/appldata/appldata_base.c | 10 ++++----
arch/s390/kernel/debug.c | 2 +-
arch/s390/mm/cmm.c | 8 +++---
arch/tile/kernel/proc.c | 4 +--
drivers/cdrom/cdrom.c | 10 ++++----
drivers/char/random.c | 4 +--
drivers/infiniband/core/ucma.c | 2 +-
drivers/md/md.c | 6 ++---
drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
drivers/scsi/scsi_sysctl.c | 6 ++---
fs/coda/sysctl.c | 4 +--
fs/dcache.c | 2 +-
fs/drop_caches.c | 2 +-
fs/eventpoll.c | 2 +-
fs/file_table.c | 4 +--
fs/fscache/main.c | 4 +--
fs/inode.c | 2 +-
fs/lockd/svc.c | 6 ++---
fs/nfs/nfs4sysctl.c | 6 ++---
fs/nfs/sysctl.c | 6 ++---
fs/notify/inotify/inotify_user.c | 2 +-
fs/ntfs/sysctl.c | 4 +--
fs/ocfs2/stackglue.c | 8 +++---
fs/proc/proc_sysctl.c | 2 +-
include/linux/key.h | 2 +-
ipc/ipc_sysctl.c | 14 +++++-----
ipc/mq_sysctl.c | 10 ++++----
kernel/sysctl.c | 2 +-
kernel/utsname_sysctl.c | 6 ++---
mm/page-writeback.c | 2 +-
mm/page_alloc.c | 12 ++++-----
security/keys/sysctl.c | 2 +-
35 files changed, 111 insertions(+), 113 deletions(-)
--
1.8.1.2.459.gbcd45b4.dirty
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 03/24] s390: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:29 [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
@ 2013-10-22 22:29 ` Joe Perches
2013-10-25 7:18 ` Heiko Carstens
2013-10-22 23:53 ` [PATCH 00/24] treewide: " David Daney
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-10-22 22:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Martin Schwidefsky, Heiko Carstens, linux390, linux-s390
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/s390/appldata/appldata_base.c | 10 +++++-----
arch/s390/kernel/debug.c | 2 +-
arch/s390/mm/cmm.c | 8 ++++----
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
index 87a2209..baff85e 100644
--- a/arch/s390/appldata/appldata_base.c
+++ b/arch/s390/appldata/appldata_base.c
@@ -48,9 +48,9 @@ static struct platform_device *appldata_pdev;
* /proc entries (sysctl)
*/
static const char appldata_proc_name[APPLDATA_PROC_NAME_LENGTH] = "appldata";
-static int appldata_timer_handler(ctl_table *ctl, int write,
+static int appldata_timer_handler(struct ctl_table *ctl, int write,
void __user *buffer, size_t *lenp, loff_t *ppos);
-static int appldata_interval_handler(ctl_table *ctl, int write,
+static int appldata_interval_handler(struct ctl_table *ctl, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos);
@@ -201,7 +201,7 @@ static void __appldata_vtimer_setup(int cmd)
* Start/Stop timer, show status of timer (0 = not active, 1 = active)
*/
static int
-appldata_timer_handler(ctl_table *ctl, int write,
+appldata_timer_handler(struct ctl_table *ctl, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
int len;
@@ -243,7 +243,7 @@ out:
* current timer interval.
*/
static int
-appldata_interval_handler(ctl_table *ctl, int write,
+appldata_interval_handler(struct ctl_table *ctl, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
int len, interval;
@@ -286,7 +286,7 @@ out:
* monitoring (0 = not in process, 1 = in process)
*/
static int
-appldata_generic_handler(ctl_table *ctl, int write,
+appldata_generic_handler(struct ctl_table *ctl, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
struct appldata_ops *ops = NULL, *tmp_ops;
diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index f1279dc..d98b888 100644
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -889,7 +889,7 @@ static int debug_active=1;
* if debug_active is already off
*/
static int
-s390dbf_procactive(ctl_table *table, int write,
+s390dbf_procactive(struct ctl_table *table, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
if (!write || debug_stoppable || !debug_active)
diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c
index 9d84a1f..61172c4 100644
--- a/arch/s390/mm/cmm.c
+++ b/arch/s390/mm/cmm.c
@@ -253,8 +253,8 @@ static int cmm_skip_blanks(char *cp, char **endp)
static struct ctl_table cmm_table[];
-static int cmm_pages_handler(ctl_table *ctl, int write, void __user *buffer,
- size_t *lenp, loff_t *ppos)
+static int cmm_pages_handler(struct ctl_table *ctl, int write,
+ void __user *buffer, size_t *lenp, loff_t *ppos)
{
char buf[16], *p;
long nr;
@@ -293,8 +293,8 @@ static int cmm_pages_handler(ctl_table *ctl, int write, void __user *buffer,
return 0;
}
-static int cmm_timeout_handler(ctl_table *ctl, int write, void __user *buffer,
- size_t *lenp, loff_t *ppos)
+static int cmm_timeout_handler(struct ctl_table *ctl, int write,
+ void __user *buffer, size_t *lenp, loff_t *ppos)
{
char buf[64], *p;
long nr, seconds;
--
1.8.1.2.459.gbcd45b4.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:29 [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-10-22 22:29 ` [PATCH 03/24] s390: " Joe Perches
@ 2013-10-22 23:53 ` David Daney
2013-10-22 23:58 ` Joe Perches
1 sibling, 1 reply; 5+ messages in thread
From: David Daney @ 2013-10-22 23:53 UTC (permalink / raw)
To: Joe Perches
Cc: linux-kernel, linux-arm-kernel, linux-ia64, linux-s390,
linux-rdma, linux-raid, linux-scsi, codalist, linux-fsdevel,
linux-cachefs, linux-nfs, linux-ntfs-dev, ocfs2-devel, keyrings,
linux-mm, linux-security-module
On 10/22/2013 03:29 PM, Joe Perches wrote:
> Joe Perches (24):
> arm: Convert use of typedef ctl_table to struct ctl_table
> ia64: Convert use of typedef ctl_table to struct ctl_table
> s390: Convert use of typedef ctl_table to struct ctl_table
> tile: Convert use of typedef ctl_table to struct ctl_table
> cdrom: Convert use of typedef ctl_table to struct ctl_table
> random: Convert use of typedef ctl_table to struct ctl_table
> infiniband: Convert use of typedef ctl_table to struct ctl_table
> md: Convert use of typedef ctl_table to struct ctl_table
> parport: Convert use of typedef ctl_table to struct ctl_table
> scsi: Convert use of typedef ctl_table to struct ctl_table
> coda: Convert use of typedef ctl_table to struct ctl_table
> fscache: Convert use of typedef ctl_table to struct ctl_table
> lockd: Convert use of typedef ctl_table to struct ctl_table
> nfs: Convert use of typedef ctl_table to struct ctl_table
> inotify: Convert use of typedef ctl_table to struct ctl_table
> ntfs: Convert use of typedef ctl_table to struct ctl_table
> ocfs2: Convert use of typedef ctl_table to struct ctl_table
> proc: Convert use of typedef ctl_table to struct ctl_table
> fs: Convert use of typedef ctl_table to struct ctl_table
> key: Convert use of typedef ctl_table to struct ctl_table
> ipc: Convert use of typedef ctl_table to struct ctl_table
> kernel: Convert use of typedef ctl_table to struct ctl_table
> mm: Convert use of typedef ctl_table to struct ctl_table
> security:keys: Convert use of typedef ctl_table to struct ctl_table
After all this work, why not go ahead and remove the typedef? That way
people won't add more users of this abomination.
David Daney
>
> arch/arm/kernel/isa.c | 6 ++---
> arch/ia64/kernel/crash.c | 4 +--
> arch/ia64/kernel/perfmon.c | 6 ++---
> arch/s390/appldata/appldata_base.c | 10 ++++----
> arch/s390/kernel/debug.c | 2 +-
> arch/s390/mm/cmm.c | 8 +++---
> arch/tile/kernel/proc.c | 4 +--
> drivers/cdrom/cdrom.c | 10 ++++----
> drivers/char/random.c | 4 +--
> drivers/infiniband/core/ucma.c | 2 +-
> drivers/md/md.c | 6 ++---
> drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
> drivers/scsi/scsi_sysctl.c | 6 ++---
> fs/coda/sysctl.c | 4 +--
> fs/dcache.c | 2 +-
> fs/drop_caches.c | 2 +-
> fs/eventpoll.c | 2 +-
> fs/file_table.c | 4 +--
> fs/fscache/main.c | 4 +--
> fs/inode.c | 2 +-
> fs/lockd/svc.c | 6 ++---
> fs/nfs/nfs4sysctl.c | 6 ++---
> fs/nfs/sysctl.c | 6 ++---
> fs/notify/inotify/inotify_user.c | 2 +-
> fs/ntfs/sysctl.c | 4 +--
> fs/ocfs2/stackglue.c | 8 +++---
> fs/proc/proc_sysctl.c | 2 +-
> include/linux/key.h | 2 +-
> ipc/ipc_sysctl.c | 14 +++++-----
> ipc/mq_sysctl.c | 10 ++++----
> kernel/sysctl.c | 2 +-
> kernel/utsname_sysctl.c | 6 ++---
> mm/page-writeback.c | 2 +-
> mm/page_alloc.c | 12 ++++-----
> security/keys/sysctl.c | 2 +-
> 35 files changed, 111 insertions(+), 113 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 23:53 ` [PATCH 00/24] treewide: " David Daney
@ 2013-10-22 23:58 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2013-10-22 23:58 UTC (permalink / raw)
To: David Daney
Cc: linux-kernel, linux-arm-kernel, linux-ia64, linux-s390,
linux-rdma, linux-raid, linux-scsi, codalist, linux-fsdevel,
linux-cachefs, linux-nfs, linux-ntfs-dev, ocfs2-devel, keyrings,
linux-mm, linux-security-module
On Tue, 2013-10-22 at 16:53 -0700, David Daney wrote:
> After all this work, why not go ahead and remove the typedef? That way
> people won't add more users of this abomination.
Hi David.
The typedef can't be removed until all the uses are gone.
I've sent this before as a single large patch as well as
individual patches.
treewide: https://lkml.org/lkml/2013/7/22/600
RemoveTypedef: https://lkml.org/lkml/2013/7/22/603
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/24] s390: Convert use of typedef ctl_table to struct ctl_table
2013-10-22 22:29 ` [PATCH 03/24] s390: " Joe Perches
@ 2013-10-25 7:18 ` Heiko Carstens
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Carstens @ 2013-10-25 7:18 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Martin Schwidefsky, linux390, linux-s390
On Tue, Oct 22, 2013 at 03:29:46PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/s390/appldata/appldata_base.c | 10 +++++-----
> arch/s390/kernel/debug.c | 2 +-
> arch/s390/mm/cmm.c | 8 ++++----
> 3 files changed, 10 insertions(+), 10 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-25 7:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 22:29 [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-10-22 22:29 ` [PATCH 03/24] s390: " Joe Perches
2013-10-25 7:18 ` Heiko Carstens
2013-10-22 23:53 ` [PATCH 00/24] treewide: " David Daney
2013-10-22 23:58 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox