From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PULL 5/8] KVM: async_pf: Provide additional direct page notification Date: Fri, 31 Jan 2014 13:24:43 +0100 Message-ID: <52EB960B.2000307@de.ibm.com> References: <1391086429-43935-1-git-send-email-borntraeger@de.ibm.com> <1391086429-43935-6-git-send-email-borntraeger@de.ibm.com> <52EB8B3B.1090806@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52EB8B3B.1090806@redhat.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Paolo Bonzini , Gleb Natapov Cc: KVM , linux-s390 , Cornelia Huck , Alexander Graf , Dominik Dingel List-ID: On 31/01/14 12:38, Paolo Bonzini wrote: > Il 30/01/2014 13:53, Christian Borntraeger ha scritto: >> +static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu, >> + struct kvm_async_pf *work) >> +{ >> +#ifndef CONFIG_KVM_ASYNC_PF_SYNC >> + kvm_arch_async_page_present(vcpu, work); >> +#endif >> +} >> + > > This is not used, should it be used in kvm_check_async_pf_completion? Yes. Looks like this got mixed up when updating the branch from before commit f2e106692d5189303997ad7b96de8d8123aa5613 (KVM: Drop FOLL_GET in GUP when doing async page fault) on top of this commit. Do you want a respin of the series or an on top patch? Christian