Re: [GIT PULL 8/9] KVM: s390: advertise KVM_CAP_S390_IRQCHIP

Christian Borntraeger
2014-07-22T18:21:29Z

On 22/07/14 10:32, Paolo Bonzini wrote:
> Il 21/07/2014 21:14, Christian Borntraeger ha scritto:
>> From: Cornelia Huck <cornelia.huck@de.ibm.com>
>>
>> We should advertise all capabilities, including those that can
>> be enabled.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> arch/s390/kvm/kvm-s390.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index dd902e6..339b34a 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -166,6 +166,7 @@ int kvm_dev_ioctl_check_extension(long ext)
>> case KVM_CAP_IOEVENTFD:
>> case KVM_CAP_DEVICE_CTRL:
>> case KVM_CAP_ENABLE_CAP_VM:
>> + case KVM_CAP_S390_IRQCHIP:
>> case KVM_CAP_VM_ATTRIBUTES:
>> case KVM_CAP_MP_STATE:
>> r = 1;
>>
>
> Should I apply this to 3.16 as well (or Cc: stable)?
>
Hmm, userspace currently does not care. But Cc: stable 3.15 and 3.16 might be "the right thing to do".

Thanks for noticing.

Christian