Re: [PATCH net] net/smc: fix incorrect SMC-D link group matching logic

patchwork-bot+netdevbpf
2024-01-26T22:10:24Z

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Jan 2024 20:39:16 +0800 you wrote:
> The logic to determine if SMC-D link group matches is incorrect. The
> correct logic should be that it only returns true when the GID is the
> same, and the SMC-D device is the same and the extended GID is the same
> (in the case of virtual ISM).
>
> It can be fixed by adding brackets around the conditional (or ternary)
> operator expression. But for better readability and maintainability, it
> has been changed to an if-else statement.
>
> [...]

Here is the summary with links:
- [net] net/smc: fix incorrect SMC-D link group matching logic
https://git.kernel.org/netdev/net/c/c3dfcdb65ec1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.