From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45718 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391044AbhALKLK (ORCPT ); Tue, 12 Jan 2021 05:11:10 -0500 Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> <20210111134303.GA3031@linux> From: David Hildenbrand Message-ID: <556a8a62-7bb2-d16b-67ea-57c87c1a6aa7@redhat.com> Date: Tue, 12 Jan 2021 11:09:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Anshuman Khandual , Oscar Salvador Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland On 12.01.21 04:51, Anshuman Khandual wrote: > > > On 1/11/21 7:13 PM, Oscar Salvador wrote: >> On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote: >>> AFAIKs, all memhp_get_pluggable_range() users pass "1". >>> >>> What about the "add_pages()-only" path? >> >> I guess you refer to memremap_pages(), right? > > Right, via pagemap_range(). > >> If so, moving the added memhp_range_allowed() check above the if-else might do >> the trick >> > We had that code in the earlier version. But dropped it, as we did > not want to add any new checks in the generic code. Can add it back > if that is preferred. I remember discussing replacing the check in __add_pages() instead. But I don't really care where the check ends up being. As discussed, at some point, we should provide versions of add_pages() and arch_add_pages() that don't immediately end in arch-code. -- Thanks, David / dhildenb