From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, KVM <kvm@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [GIT PULL 1/1] KVM: s390: Fix hang VCPU hang/loop regression
Date: Thu, 30 Jul 2015 13:43:58 +0200 [thread overview]
Message-ID: <55BA0DFE.9080905@de.ibm.com> (raw)
In-Reply-To: <55BA0CB5.1090605@redhat.com>
Am 30.07.2015 um 13:38 schrieb Paolo Bonzini:
>
>
> On 30/07/2015 13:22, Christian Borntraeger wrote:
>> static int kvm_s390_handle_requests(struct kvm_vcpu *vcpu)
>> {
>> - if (!vcpu->requests)
>> - return 0;
>> retry:
>> kvm_s390_vcpu_request_handled(vcpu);
>> + if (!vcpu->requests)
>> + return 0;
>> /*
>
> Should kvm_s390_vcpu_request_handled(vcpu); go before the retry label?
>
> It shouldn't be too common to have two requests, and you're doing an
> extra atomic operation to clear PROG_REQUEST.
Handling a request is slow path anyway and my last optimization was not
considering all side effects - so give me some time to comsume your comment
to make it better this time....
[...]
> This of course should be for 4.3
yes :-)
> ---I've pulled your branch into kvm/master.
prev parent reply other threads:[~2015-07-30 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 11:22 [GIT PULL 0/1] KVM: s390: bugfix for kvm/master (4.2) Christian Borntraeger
2015-07-30 11:22 ` [GIT PULL 1/1] KVM: s390: Fix hang VCPU hang/loop regression Christian Borntraeger
2015-07-30 11:38 ` Paolo Bonzini
2015-07-30 11:43 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA0DFE.9080905@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).