Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully

Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully

[Paolo Bonzini]

On 06/08/2015 19:05, Nicholas Krause wrote:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
>  		if (kvm->arch.use_irqchip) {
>  			/* Set up dummy routing. */
>  			memset(&routing, 0, sizeof(routing));
> -			kvm_set_irq_routing(kvm, &routing, 0, 0);
> -			r = 0;
> +			r = kvm_set_irq_routing(kvm, &routing, 0, 0);
>  		}
>  		break;
>  	}
> 

Seems good.

Paolo

Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully

[Christian Borntraeger]

Am 06.08.2015 um 19:05 schrieb Nicholas Krause:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
>  		if (kvm->arch.use_irqchip) {
>  			/* Set up dummy routing. */
>  			memset(&routing, 0, sizeof(routing));
> -			kvm_set_irq_routing(kvm, &routing, 0, 0);
> -			r = 0;
> +			r = kvm_set_irq_routing(kvm, &routing, 0, 0);
>  		}
>  		break;
>  	}
> 

Thanks, applied with changed prefix (KVM: s390:)

Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully

[Paolo Bonzini]

On 10/08/2015 17:21, nick wrote:
> > Seems good.
> > 
> > Paolo
>
> If it makes it easier for you to trust my patches I can show at least 10 bug fixes for other subsystems
> to prove that I am trying to do this correctly.

That's up to those maintainers...

I definitely see some improvement in your patches, though I still
haven't answered the submissions that in my opinion are a bit more
problematic.

Paolo