* Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully
[not found] <1438880754-27149-1-git-send-email-xerofoify@gmail.com>
@ 2015-08-07 7:18 ` Paolo Bonzini
[not found] ` <55C8C16F.2020906@gmail.com>
2015-08-07 9:09 ` Christian Borntraeger
1 sibling, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2015-08-07 7:18 UTC (permalink / raw)
To: Nicholas Krause, gleb
Cc: borntraeger, cornelia.huck, linux390, kvm, linux-s390,
linux-kernel
On 06/08/2015 19:05, Nicholas Krause wrote:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/s390/kvm/kvm-s390.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> if (kvm->arch.use_irqchip) {
> /* Set up dummy routing. */
> memset(&routing, 0, sizeof(routing));
> - kvm_set_irq_routing(kvm, &routing, 0, 0);
> - r = 0;
> + r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> }
> break;
> }
>
Seems good.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully
[not found] <1438880754-27149-1-git-send-email-xerofoify@gmail.com>
2015-08-07 7:18 ` [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully Paolo Bonzini
@ 2015-08-07 9:09 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2015-08-07 9:09 UTC (permalink / raw)
To: Nicholas Krause, gleb
Cc: pbonzini, cornelia.huck, linux390, kvm, linux-s390, linux-kernel
Am 06.08.2015 um 19:05 schrieb Nicholas Krause:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/s390/kvm/kvm-s390.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> if (kvm->arch.use_irqchip) {
> /* Set up dummy routing. */
> memset(&routing, 0, sizeof(routing));
> - kvm_set_irq_routing(kvm, &routing, 0, 0);
> - r = 0;
> + r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> }
> break;
> }
>
Thanks, applied with changed prefix (KVM: s390:)
^ permalink raw reply [flat|nested] 3+ messages in thread