* [PATCH] kvm/s390: drop unpaired smp_mb
@ 2016-01-05 16:20 Michael S. Tsirkin
2016-01-07 8:25 ` Christian Borntraeger
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2016-01-05 16:20 UTC (permalink / raw)
To: linux-kernel
Cc: Gleb Natapov, Paolo Bonzini, Christian Borntraeger, Cornelia Huck,
Martin Schwidefsky, Heiko Carstens, kvm, linux-s390
smp_mb on vcpu destroy isn't paired with anything, violating pairing
rules, and seems to be useless.
Drop it.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Untested.
arch/s390/kvm/kvm-s390.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 8465892..7305d2c 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1195,7 +1195,6 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
(__u64) vcpu->arch.sie_block)
vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0;
}
- smp_mb();
if (kvm_is_ucontrol(vcpu->kvm))
gmap_free(vcpu->arch.gmap);
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm/s390: drop unpaired smp_mb
2016-01-05 16:20 [PATCH] kvm/s390: drop unpaired smp_mb Michael S. Tsirkin
@ 2016-01-07 8:25 ` Christian Borntraeger
0 siblings, 0 replies; 2+ messages in thread
From: Christian Borntraeger @ 2016-01-07 8:25 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: Gleb Natapov, Paolo Bonzini, Cornelia Huck, Martin Schwidefsky,
Heiko Carstens, kvm, linux-s390
On 01/05/2016 05:20 PM, Michael S. Tsirkin wrote:
> smp_mb on vcpu destroy isn't paired with anything, violating pairing
> rules, and seems to be useless.
>
> Drop it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
(I had to fix this up a little to match kvm/next)
Thanks
> ---
>
> Untested.
>
> arch/s390/kvm/kvm-s390.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 8465892..7305d2c 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1195,7 +1195,6 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
> (__u64) vcpu->arch.sie_block)
> vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0;
> }
> - smp_mb();
>
> if (kvm_is_ucontrol(vcpu->kvm))
> gmap_free(vcpu->arch.gmap);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-07 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-05 16:20 [PATCH] kvm/s390: drop unpaired smp_mb Michael S. Tsirkin
2016-01-07 8:25 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).