* Build failures (s390) in -next due to 'mm, printk: introduce new format string for flags'
@ 2016-01-29 15:35 Guenter Roeck
2016-01-29 15:40 ` Vlastimil Babka
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2016-01-29 15:35 UTC (permalink / raw)
To: Vlastimil Babka, linux-next@vger.kernel.org
Cc: Michal Hocko, Andrew Morton, linux-s390, Heiko Carstens
Hi,
s390 builds in -next fail with lots of errors such as:
include/linux/jump_label.h: In function 'static_key_count':
include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
return atomic_read(&key->enabled);
...
./arch/s390/include/asm/atomic.h: At top level:
./arch/s390/include/asm/atomic.h:74:19: error: static declaration of 'atomic_read' follows non-static declaration
static inline int atomic_read(const atomic_t *v)
As far as I can see this is due to recursive inclusion of linux/atomic.h
(which in turn is triggered by recursive inclusion of linux/mmdebug.h).
I was able to "fix" the problem by removing the inclusion of mmdebug.h from
arch/s390/include/asm/cmpxchg.h. That is not a proper fix, though, since the file
uses VM_BUG_ON(), which is defined in mmdebug.h.
The problem was introduced with 'mm, printk: introduce new format string for flags'.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build failures (s390) in -next due to 'mm, printk: introduce new format string for flags'
2016-01-29 15:35 Build failures (s390) in -next due to 'mm, printk: introduce new format string for flags' Guenter Roeck
@ 2016-01-29 15:40 ` Vlastimil Babka
0 siblings, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2016-01-29 15:40 UTC (permalink / raw)
To: Guenter Roeck, linux-next@vger.kernel.org
Cc: Michal Hocko, Andrew Morton, linux-s390, Heiko Carstens
On 01/29/2016 04:35 PM, Guenter Roeck wrote:
> Hi,
>
> s390 builds in -next fail with lots of errors such as:
>
> include/linux/jump_label.h: In function 'static_key_count':
> include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
> return atomic_read(&key->enabled);
> ...
> ./arch/s390/include/asm/atomic.h: At top level:
> ./arch/s390/include/asm/atomic.h:74:19: error: static declaration of 'atomic_read' follows non-static declaration
> static inline int atomic_read(const atomic_t *v)
>
> As far as I can see this is due to recursive inclusion of linux/atomic.h
> (which in turn is triggered by recursive inclusion of linux/mmdebug.h).
>
> I was able to "fix" the problem by removing the inclusion of mmdebug.h from
> arch/s390/include/asm/cmpxchg.h. That is not a proper fix, though, since the file
> uses VM_BUG_ON(), which is defined in mmdebug.h.
>
> The problem was introduced with 'mm, printk: introduce new format string for flags'.
Yeah sorry about that, I sent a fixed fix:
http://marc.info/?l=linux-mm&m=145406672221395&w=2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-29 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-29 15:35 Build failures (s390) in -next due to 'mm, printk: introduce new format string for flags' Guenter Roeck
2016-01-29 15:40 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).