* Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl() [not found] ` <56C77A8B.7080800@zytor.com> @ 2016-02-19 21:06 ` Luis R. Rodriguez 2016-02-22 2:55 ` H. Peter Anvin 0 siblings, 1 reply; 4+ messages in thread From: Luis R. Rodriguez @ 2016-02-19 21:06 UTC (permalink / raw) To: H. Peter Anvin, schwidefsky, heiko.carstens, linux-s390 Cc: Luis R. Rodriguez, tglx, mingo, bp, x86, linux-kernel, luto, boris.ostrovsky, rusty, david.vrabel, konrad.wilk, mcb30, jgross, ming.lei, gregkh, arnd, linux-arch, linux, benh, jbaron, ananth, anil.s.keshavamurthy, davem, masami.hiramatsu.pt, andriy.shevchenko, dwmw2, xen-devel On Fri, Feb 19, 2016 at 12:26:51PM -0800, H. Peter Anvin wrote: > On 02/19/2016 05:45 AM, Luis R. Rodriguez wrote: > > With a generic linker tables solution in place we > > need a general asm solution for declaring entries > > with asm. The first easy target is to cover the C > > asm declarations, guard the header file for now > > and define a first generic entry push_section_tbl() > > to be used later for custom linker table annotations. > > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > > --- > > include/asm-generic/sections.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/asm-generic/sections.h b/include/asm-generic/sections.h > > index af0254c09424..f5ea98bd85d2 100644 > > --- a/include/asm-generic/sections.h > > +++ b/include/asm-generic/sections.h > > @@ -3,8 +3,10 @@ > > > > /* References to section boundaries */ > > > > +#ifndef __ASSEMBLY__ > > #include <linux/compiler.h> > > #include <linux/types.h> > > +#include <linux/sections.h> > > > > /* > > * Usage guidelines: > > @@ -128,4 +130,12 @@ static inline bool init_section_intersects(void *virt, size_t size) > > return memory_intersects(__init_begin, __init_end, virt, size); > > } > > > > +/* > > + * Some architectures do not like the "\t" at the end (s39), we should be > > + * able to generalize this further, but so far this covers most architectures. > > + */ > > +#define push_section_tbl(section, name, level, flags) \ > > + ".pushsection " SECTION_TBL(section,name,level) ", \"" #flags "\"\n\t" > > +#endif > > + > > I think the \n\t is unnecessary. Super! I wonder if we we can just use this on s390 as well without it pooping? I ask as this would set a precedent. Luis ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl() 2016-02-19 21:06 ` [RFC v2 4/7] asm/sections: add a generic push_section_tbl() Luis R. Rodriguez @ 2016-02-22 2:55 ` H. Peter Anvin 2016-02-26 14:56 ` Heiko Carstens 0 siblings, 1 reply; 4+ messages in thread From: H. Peter Anvin @ 2016-02-22 2:55 UTC (permalink / raw) To: Luis R. Rodriguez, schwidefsky, heiko.carstens, linux-s390 Cc: tglx, mingo, bp, x86, linux-kernel, luto, boris.ostrovsky, rusty, david.vrabel, konrad.wilk, mcb30, jgross, ming.lei, gregkh, arnd, linux-arch, linux, benh, jbaron, ananth, anil.s.keshavamurthy, davem, masami.hiramatsu.pt, andriy.shevchenko, dwmw2, xen-devel On 02/19/16 13:06, Luis R. Rodriguez wrote: >> >> I think the \n\t is unnecessary. > > Super! I wonder if we we can just use this on s390 as well without it pooping? > I ask as this would set a precedent. > Ask Heike, but I think just ; or \n ought be be fine. I do not know of *any* case where \t at the end of a string would ever be necessary, and it would *always* be possible to replace it with a space in a pinch. -hpa ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl() 2016-02-22 2:55 ` H. Peter Anvin @ 2016-02-26 14:56 ` Heiko Carstens 2016-05-20 19:53 ` Luis R. Rodriguez 0 siblings, 1 reply; 4+ messages in thread From: Heiko Carstens @ 2016-02-26 14:56 UTC (permalink / raw) To: H. Peter Anvin Cc: Luis R. Rodriguez, schwidefsky, linux-s390, tglx, mingo, bp, x86, linux-kernel, luto, boris.ostrovsky, rusty, david.vrabel, konrad.wilk, mcb30, jgross, ming.lei, gregkh, arnd, linux-arch, linux, benh, jbaron, ananth, anil.s.keshavamurthy, davem, masami.hiramatsu.pt, andriy.shevchenko, dwmw2, xen-devel On Sun, Feb 21, 2016 at 06:55:05PM -0800, H. Peter Anvin wrote: > On 02/19/16 13:06, Luis R. Rodriguez wrote: > >> > >> I think the \n\t is unnecessary. > > > > Super! I wonder if we we can just use this on s390 as well without it pooping? > > I ask as this would set a precedent. > > > > Ask Heike, but I think just ; or \n ought be be fine. I do not know of > *any* case where \t at the end of a string would ever be necessary, and > it would *always* be possible to replace it with a space in a pinch. \n should be fine on s390. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl() 2016-02-26 14:56 ` Heiko Carstens @ 2016-05-20 19:53 ` Luis R. Rodriguez 0 siblings, 0 replies; 4+ messages in thread From: Luis R. Rodriguez @ 2016-05-20 19:53 UTC (permalink / raw) To: Heiko Carstens Cc: H. Peter Anvin, Luis R. Rodriguez, schwidefsky, linux-s390, tglx, mingo, bp, x86, linux-kernel, luto, boris.ostrovsky, rusty, david.vrabel, konrad.wilk, mcb30, jgross, ming.lei, gregkh, arnd, linux-arch, linux, benh, jbaron, ananth, anil.s.keshavamurthy, davem, masami.hiramatsu.pt, andriy.shevchenko, dwmw2, xen-devel, torvalds On Fri, Feb 26, 2016 at 03:56:04PM +0100, Heiko Carstens wrote: > On Sun, Feb 21, 2016 at 06:55:05PM -0800, H. Peter Anvin wrote: > > On 02/19/16 13:06, Luis R. Rodriguez wrote: > > >> > > >> I think the \n\t is unnecessary. > > > > > > Super! I wonder if we we can just use this on s390 as well without it pooping? > > > I ask as this would set a precedent. > > > > > > > Ask Heike, but I think just ; or \n ought be be fine. I do not know of > > *any* case where \t at the end of a string would ever be necessary, and > > it would *always* be possible to replace it with a space in a pinch. > > \n should be fine on s390. Great, thanks, I'll move forward with just \n in v3. Luis ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-20 19:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1455889559-9428-1-git-send-email-mcgrof@kernel.org>
[not found] ` <1455889559-9428-5-git-send-email-mcgrof@kernel.org>
[not found] ` <56C77A8B.7080800@zytor.com>
2016-02-19 21:06 ` [RFC v2 4/7] asm/sections: add a generic push_section_tbl() Luis R. Rodriguez
2016-02-22 2:55 ` H. Peter Anvin
2016-02-26 14:56 ` Heiko Carstens
2016-05-20 19:53 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).