From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288BD482FF for ; Sun, 11 Aug 2024 10:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723371899; cv=none; b=ZZDD9KLjwiti3n3SyjPo4+wo+S45/xgj58uvt9IaMTNWmI7LRWu0aXL6u7bA0mEQ0xOTe5kVudXo0Y2DqzzesxbHEYIzZ0ls5qXo6fhpSr26ZVY1/HCj7Dvs8U6GNtv8G2F/TXhbrEcG4RB9XQqYuCFyYHvk0CVSghNhpAE2qaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723371899; c=relaxed/simple; bh=ylSIxJZQmnA3l5sPWJq1gVuf83mOLw/7NuHyIi+LBYU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=hUMEVGMfl8eSSWX6qamDhsXoHLahvHW6aAqNtNu5s9PvXSICUDv0wC1vsS81HHUe8Xf8Y8B/S2WrXTnhgtbfAAJSD3ATLveigkZw5YRZ806agP6aqOFBzSwMc4ScUQzyuiNcigDutBe41HcfszQtX4rZReRO2ei7o99STEh9j1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=W5GJyHJq; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="W5GJyHJq" Message-ID: <60557472-62b2-4323-b952-cf81e5560c16@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723371895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hc+SO9yvYqxLbr+jOZbu3cqsJuIGSGpCQ0uk1+NIK7E=; b=W5GJyHJqlkt55kQW8Jx/oj1L/auz359xgrNJlaRbBQJQ9iJ6sNg/e4ahGX4lSWhYYevtPu ZPYqtVge+Qssrp2jK9syv8IbwvLihTd06d+ZpfEw55HIfSlt9BSyrd+UUytHvkNhgrd2rM CJZR1dbjK/+vNwh2mR19YWWtrRh4kDg= Date: Sun, 11 Aug 2024 18:24:46 +0800 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 4/4] RDMA/rxe: Set queue pair cur_qp_state when being queried X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun To: Leon Romanovsky Cc: Liu Jian , linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, jgg@ziepe.ca, zyjzyj2000@gmail.com, wenjia@linux.ibm.com, jaka@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, guwen@linux.alibaba.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com References: <20240809083148.1989912-1-liujian56@huawei.com> <20240809083148.1989912-5-liujian56@huawei.com> <72029ea9-f550-470e-9e5d-42e95ca4592e@linux.dev> <20240811083133.GA5925@unreal> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2024/8/11 18:22, Zhu Yanjun 写道: > > > 在 2024/8/11 16:31, Leon Romanovsky 写道: >> On Fri, Aug 09, 2024 at 07:06:34PM +0800, Zhu Yanjun wrote: >>> 在 2024/8/9 16:31, Liu Jian 写道: >>>> Same with commit e375b9c92985 ("RDMA/cxgb4: Set queue pair state when >>>> being queried"). The API for ib_query_qp requires the driver to set >>>> cur_qp_state on return, add the missing set. >>>> >>> Add the following? >>> Cc:stable@vger.kernel.org >> There is no need to add stable tag for RXE driver. Distros are not >> supporting this driver, which is used for development and not for >> production. > > I do not mean that this driver is supported in Distros. > > I mean that QP cur_qp_state is not set when being queried in rxe. In > other rdma drivers, this is set. > > This should be a problem in RXE. So I suggest to add "CC: > stable@vger.kernel.org". > > As such, the stable branch will backport this commit to fix this > problem in RXE. > Sorry. My mistakes. No need to add this "CC: stable@vger.kernel.org" Zhu Yanjun > Anyway, thanks a lot for your reporting and fixing this problem in RXE. > > Best Regards, > > Zhu Yanjun > >> Thanks >> >>>> Fixes: 8700e3e7c485 ("Soft RoCE driver") >>>> Signed-off-by: Liu Jian >>>> --- >>>> drivers/infiniband/sw/rxe/rxe_verbs.c | 2 ++ >>>> 1 file changed, 2 insertions(+) > -- > Best Regards, > Yanjun.Zhu -- Best Regards, Yanjun.Zhu